Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Out of date tuning documentation #1310

Open
kahmed10 opened this issue Mar 19, 2021 · 3 comments
Open

Out of date tuning documentation #1310

kahmed10 opened this issue Mar 19, 2021 · 3 comments
Labels
bug Bug fix Documentation Documentation TuningScripts Tuning automation & improvements

Comments

@kahmed10
Copy link

Recent updates to the scripts (#1258?) under Tensile/tuning/scripts are not reflected under Tensile/tuning/README.md. For example, provision_tuning.sh has a new format:

Usage: ./tuning/scripts/provision_tuning.sh WORKING_PATH LOG_PATH OUTPUT_SUFFIX.yaml LIBRARY [options]

But the documentation is showing an example with the following args:

./tuning/scripts/provision_tuning.sh -w tensile_tuning -z logs/inception_rocblas-configs_unique.log -r tensile_tuning/tensile/Tensilen-rocblas-configs_unique.log -o tf_inception.yaml -y sgemm -l vega20
@kahmed10 kahmed10 changed the title Out of date tuning documentations Out of date tuning documentation Mar 19, 2021
@kahmed10 kahmed10 added bug Bug fix Documentation Documentation TuningScripts Tuning automation & improvements labels Mar 19, 2021
@benjaminulmer
Copy link
Contributor

Good catch. Looks like this README hasn't been updated in quite some time.

In the meantime, the tuning doc has more up-to-date information on how to use these scripts.

@kahmed10
Copy link
Author

kahmed10 commented May 7, 2021

Thanks for the update. Please close this issue when the documentation gets updated.

@ppanchad-amd
Copy link

@kahmed10 Internal ticket has been created to fix documentation. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug fix Documentation Documentation TuningScripts Tuning automation & improvements
Projects
None yet
Development

No branches or pull requests

3 participants