Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call to resetOdometry() in getAutonomousCommand() is not made when SwerveControllerCommand is executed as it should #13

Open
gartaud opened this issue Nov 5, 2023 · 2 comments

Comments

@gartaud
Copy link

gartaud commented Nov 5, 2023

The call to resetOdometry() in getAutonomousCommand() is not made when SwerveControllerCommand is executed as it should. Rather it is made when getAutonomousCommand() is called.

This is not good as resetOdometry() requires the current pose prior to the execution of the SwerveControllerCommand.

For more info, see discussion at
https://www.chiefdelphi.com/t/how-to-define-the-shortest-trajectory-in-reverse-with-edu-wpi-first-math-trajectory-trajectorygenerator/443549/20

@gartaud
Copy link
Author

gartaud commented Nov 5, 2023

See also wpilibsuite/allwpilib#5884

@gartaud
Copy link
Author

gartaud commented Jan 7, 2024

@ElliotScher Can you port your WPILib fix back to this template? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant