Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAINT: Fix OMP warning coming from numba #730

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

MAINT: Fix OMP warning coming from numba #730

wants to merge 3 commits into from

Conversation

kp992
Copy link
Contributor

@kp992 kp992 commented Jun 8, 2024 •
edited
Loading

Fixes #627
Fixes #729

I have tested locally and with the current main and pip install ., I get:

% python
Python 3.10.12 | packaged by conda-forge | (main, Jun 23 2023, 22:41:52) [Clang 15.0.7 ] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import quantecon
OMP: Info #276: omp_set_nested routine deprecated, please use omp_set_max_active_levels instead.

On this branch:

% python       
Python 3.10.12 | packaged by conda-forge | (main, Jun 23 2023, 22:41:52) [Clang 15.0.7 ] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import quantecon
>>>

@pep8speaks
Copy link

pep8speaks commented Jun 8, 2024 •
edited
Loading

Hello @kp992! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-06-10 01:30:40 UTC

@kp992
Copy link
Contributor Author

kp992 commented Jun 8, 2024

@mmcky Please check if this looks good to you.

@kp992
Copy link
Contributor Author

kp992 commented Jun 8, 2024 •
edited
Loading

Seems like CI needs fixing. Opened #731.

@coveralls
Copy link

Coverage Status

coverage: 93.043% (+0.002%) from 93.041%
when pulling 79b9f63 on kp992:i-627
into bea8295 on QuantEcon:main.

@oyamad
Copy link
Member

oyamad commented Jun 10, 2024

Thanks for taking care of this issue, but I think I am against changing the user's global setting in a library. What do you guys think?

@mmcky
Copy link
Contributor

mmcky commented Jun 10, 2024

thanks @oyamad just diving into this myself.

I agree with @oyamad -- it is not generally a good idea to change global settings for users due to a package import. Is this controllable through checking numba versions and issuing a helpful message for switching it off? Is numba going to fix this warning message?

@oyamad
Copy link
Member

oyamad commented Jun 10, 2024

There is an open PR numba/numba#7705; I don't know what its current status is (it has not been merged).

@mmcky
Copy link
Contributor

mmcky commented Nov 27, 2024

Just a status update that link to the issue above is still open, but looks like numba will resolve this soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Warning message when import quantecon MAINT: Fix deprecation warning from Numba
5 participants
@kp992 @pep8speaks @coveralls @oyamad @mmcky