Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

repeated names in directory #350

Open
jstac opened this issue Oct 15, 2017 · 3 comments
Open

repeated names in directory #350

jstac opened this issue Oct 15, 2017 · 3 comments
Labels
discuss

Comments

@jstac
Copy link
Contributor

jstac commented Oct 15, 2017

There are a lot of repeated names in the list of attributes, filename and then class or function name:

ss

e.g., compute_fixed_point and compute_pf, ECDF and ecdf. We don't really need the module names here. Should they be hidden, perhaps? What's the convention?
@jstac
Copy link
Contributor Author

jstac commented Oct 15, 2017

numba also appears as an attribute of the library...

@mmcky
Copy link
Contributor

mmcky commented Oct 15, 2017 •
edited
Loading

Hey @jstac I am not sure what the convention is here. I will have a look at pandas or another major project to see what style they adopt. We can adopt a style of prepending _ to module names and external packages on import. That hides them to introspection.

@Smit-create Smit-create mentioned this issue Feb 11, 2022
Merged
@Smit-create
Copy link
Member

@jstac @mmcky Please let me know your reviews regarding #601

@oyamad oyamad added the discuss label Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discuss
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jstac @oyamad @mmcky @Smit-create