Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Index.IsTradable Can Be Set #7610

Merged
merged 3 commits into from
Dec 7, 2023
Merged

Index.IsTradable Can Be Set #7610

merged 3 commits into from
Dec 7, 2023

Conversation

AlexCatarino
Copy link
Member

Description

Indices are not tradable. LEAN will not set it to true, but the users can for backtesting.

Motivation and Context

Give users more control in backtesting.

Requires Documentation Change

No.

How Has This Been Tested?

Current unit tests.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves implementation)
  • Performance (non-breaking change which improves performance. Please add associated performance test and results)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional change (xml comments/documentation/etc)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

@AlexCatarino AlexCatarino force-pushed the feature-index-is-tradable branch 2 times, most recently from b2a8410 to b150d04 Compare December 6, 2023 14:30
@AlexCatarino
Index.IsTradable Can Be Set
503d2b3 
Indices are not tradable. LEAN will not set it to `true`, but the users can for backtesting.
Martin-Molinero
Martin-Molinero approved these changes Dec 6, 2023
View reviewed changes
Copy link
Member

@Martin-Molinero Martin-Molinero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! 👍

@Martin-Molinero Martin-Molinero merged commit b847743 into QuantConnect:master Dec 7, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Martin-Molinero Martin-Molinero Martin-Molinero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexCatarino @Martin-Molinero