Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better gRPC Support through gRPC Interceptors #93

Open
mRs- opened this issue Feb 19, 2022 · 4 comments
Open

Better gRPC Support through gRPC Interceptors #93

mRs- opened this issue Feb 19, 2022 · 4 comments
Assignees
Labels
Done This Ticket is done enhancement New feature or request

Comments

@mRs-
Copy link
Contributor

mRs- commented Feb 19, 2022

Hi, I'm currently implementing a gRPC Interceptor to track all the traffic via atlantis.

It's working fine currently, but for streaming it would be awesome to have some API to support streaming like WebSocket is aready doing it. Is it possible to expose this to the public manual API? I can even share the complete interceptor for gRPC later on and it would be easy for other projects to just implement the Atlantis Interceptor in all gRPC calls 😀

@NghiaTranUIT NghiaTranUIT self-assigned this Feb 19, 2022
@NghiaTranUIT
Copy link
Member

It's awesome if you can share the complete interceptor of gRPC. We will integrate it into Atlantis 🎉

Is it possible to expose this to the public manual API?

Yes, it's as long as I know which funds that you need to be public 👍

@NghiaTranUIT NghiaTranUIT added the enhancement New feature or request label Feb 19, 2022
@mRs-
Copy link
Contributor Author

mRs- commented Feb 20, 2022

Seems like I have the first breakthrough!

image

@NghiaTranUIT
Copy link
Member

Awesome 🎉 If you don't mind, please open a PR. I believe that it can be beneficial for gRPC developers 😄

I appreciate it 👍

@mRs-
Copy link
Contributor Author

mRs- commented Feb 21, 2022

You can find my Pull Request here: #94

@NghiaTranUIT NghiaTranUIT added the Done This Ticket is done label Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Done This Ticket is done enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants