Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should find a previous WS Package! #84

Open
khoogheem opened this issue Sep 9, 2021 · 10 comments
Open

Should find a previous WS Package! #84

khoogheem opened this issue Sep 9, 2021 · 10 comments
Assignees

Comments

@khoogheem
Copy link

Proxyman version? 2.32.1 (23210)

macOS Version? 11.4

Steps to reproduce

when proxyman is not running... I get these issue:

Fatal error: Something went wrong! Should find a previous WS Package! Please contact the author!: file Atlantis/Atlantis.swift, line 358

@NghiaTranUIT NghiaTranUIT self-assigned this Sep 10, 2021
@kjoe07
Copy link

kjoe07 commented Feb 1, 2022

got this same crash any news on it

@NghiaTranUIT
Copy link
Member

@kjoe07 Just wondering: Which Atlantis version and your iOS version are you using? I could not reproduce this issue in the last time and I'd like to investigate it again 👍

@kjoe07
Copy link

kjoe07 commented Feb 1, 2022

iOS 15.3 Xcode 13.2.1 macOS Monterrey proxyMan latest version, Install with swift package manager using urlSession for sockets, chafed to 1.14.0 and 1.9.0 and got the same error every time also have amplify as dependency and guess is using starscream

@NghiaTranUIT
Copy link
Member

@kjoe07 if you're using Starscream to perform the Websocket, do you use NativeEngine by setting useCustomEngine: false?

for example:

let ws = Websocket(request: myRequest, useCustomEngine: false)

Ref: https://github.com/daltoniam/Starscream/blob/c68359159dcf0b5de9b536b9a959e9e435e968d3/Sources/Starscream/WebSocket.swift#L118


It's because, by default, Starscream would use TCPTransport rather than URLSessionWebsocketTask behind the hood. On the other hand, Atlantis only supports URLSessionWebsocketTask.

@kjoe07
Copy link

kjoe07 commented Feb 1, 2022

I now I don't use start scream it's a dependency for amplify not for my app my sockets connections are handle with url session

@VaslD
Copy link
Contributor

VaslD commented Apr 11, 2023

@NghiaTranUIT I've also encountered this. Does Atlantis support initialization elsewhere other than AppDelegate?

I wrapped Atlantis in a toggle switch in app settings. If a WS connection was mid-flight and I then enabled Atlantis (setup with no specific host), this crash would very likely be triggered.

@NghiaTranUIT
Copy link
Member

Technically, you can initialize the Atlantis framework anywhere in the app, not just AppDelegate.

When the app is crashed, can you take a screenshot where the crash occurs?

@vani2
Copy link

vani2 commented Apr 21, 2023

Screenshot 2023-04-21 at 15 23 20

It happens when I manually try to cancel URLSessionWebSocketTask with .normalClosure.

@NghiaTranUIT
Copy link
Member

@vani2 Thanks. I will look on it today 👍

@NghiaTranUIT
Copy link
Member

@vani2 let's update to Atlantis 1.21.1, it should fix the crash 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants