Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub PR Workflow Check: Talawa API app starts (Docker) #2638

Open
palisadoes opened this issue Nov 3, 2024 · 9 comments
Open

GitHub PR Workflow Check: Talawa API app starts (Docker) #2638

palisadoes opened this issue Nov 3, 2024 · 9 comments
Assignees
Labels
bug Something isn't working feature request good first issue Good for newcomers no-issue-activity No issue activity test Testing application

Comments

@palisadoes
Copy link
Contributor

palisadoes commented Nov 3, 2024

Describe the bug

The GitHub PR workflow does not check whether the Talawa API app can start in Docker

To Reproduce

Steps to reproduce the behavior:

  1. Make a change to the repo that makes the Talawa API app fail to start in Docker
  2. Trigger the workflow to run as part of a PR
  3. The workflow passes

and as expected:

  1. Make a change to the repo that makes the Talawa API app start in Docker
  2. Trigger the workflow to run as part of a PR
  3. The workflow passes

Expected behavior

Steps to reproduce the behavior:

  1. Make a change to the repo that makes the Talawa API app fail to start in Docker
  2. Trigger the workflow to run as part of a PR
  3. The workflow fails

and as expected:

  1. Make a change to the repo that makes the Talawa API app start in Docker
  2. Trigger the workflow to run as part of a PR
  3. The workflow passes

We now have a test data that can be loaded that resides in the repo. This should be used as part of the test.

Actual behavior

  • The Talawa API app isn't started and tested in the PR workflow

Screenshots

  • N/A

Additional details

  1. It must verify starting with Docker
  2. Use this issue for reference:
    1. CI/CD : Check for Starting a Server. #1343

Potential internship candidates

@palisadoes palisadoes added feature request bug Something isn't working good first issue Good for newcomers test Testing application labels Nov 3, 2024
@github-actions github-actions bot added the unapproved Unapproved for Pull Request label Nov 3, 2024
@rahulrana701
Copy link

@palisadoes I would like to work on this issue

@palisadoes palisadoes removed the unapproved Unapproved for Pull Request label Nov 4, 2024
@Kunalpal216
Copy link

I would like to work on this issue. @rahulrana701 any updates from you ?

@rahulrana701
Copy link

@Kunalpal216 yeah I am working on it

@palisadoes
Copy link
Contributor Author

During the week of November 11, 2024 we will start a code freeze on the develop branches in Talawa, Talawa Admin and Talawa-API.

We have completed a project to convert the Talawa-API backend to use PostgreSQL. Work will then begin with us merging code in the develop branches to a new develop-postrgres branch in each repository.

Planning activities for this will be managed in our #talawa-projects slack channel. A GitHub project will be created to track specially labeled issues. We completed a similar exercise last year using a similar methodology.

Starting November 12, California time no new PRs will be accepted against the develop branch. They must be applied to the develop-postrgres branch.

There are some GSoC project features that will need to be merged into develop. These will be the only exceptions.

This activity and the post GSoC 2024 start date was announced in our #general Slack channel last month as a pinned post.

@nilaygit-10721
Copy link

Hello @palisadoes, may I work on this issue?

@RajvardhanT7747
Copy link

Hello @palisadoes I am very excited to contribute to these issue , May I contribute for these issue ?

@Cioppolo14
Copy link
Contributor

If the issue has already been assigned, please don't ask to be assigned. We want everyone to get a chance.

@RajvardhanT7747
Copy link

RajvardhanT7747 commented Nov 12, 2024 via email

Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feature request good first issue Good for newcomers no-issue-activity No issue activity test Testing application
Projects
Status: Backlog
Development

No branches or pull requests

6 participants