Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pretty articles #91

Merged
merged 4 commits into from
Mar 28, 2018
Merged

Pretty articles #91

merged 4 commits into from
Mar 28, 2018

Conversation

mpacer
Copy link
Collaborator

@mpacer mpacer commented Mar 4, 2018

This provides a prettier way to display Articles when in the jupyter notebook, see image below.

The article's title links to the plos webpage, the doi links to the doi.org webpage.

image

You don't want to know how long it took to get the title to align properly…inline-flex for the win.

@sbassi
Copy link
Collaborator

sbassi commented Mar 4, 2018

This feature is worth mentioning in the paper, it could be next to the mention to the Jupyter notebook example. See PR #62

@mpacer
Copy link
Collaborator Author

mpacer commented Mar 4, 2018

Agreed, but I still think we need a lot better docs before we come anywhere near submitting a JOSS paper.

But it should also definitely make its way into the scipy paper assuming that the proposal gets accepted (along with the design principles for the stuff in #89).

@mpacer
Copy link
Collaborator Author

mpacer commented Mar 4, 2018

The utils bit is necessary for the _repr_html_ to work so i'll squash that.

@mpacer mpacer force-pushed the pretty_articles branch 2 times, most recently from 6758f7f to 906500d Compare March 6, 2018 02:14
@eseiver
Copy link
Collaborator

eseiver commented Mar 28, 2018

LGTM. Rebased on master, all tests passing

@eseiver eseiver merged commit d0fff94 into PLOS:master Mar 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants