Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend unit tests #11

Open
eseiver opened this issue Sep 25, 2017 · 0 comments
Open

Extend unit tests #11

eseiver opened this issue Sep 25, 2017 · 0 comments
Assignees
Labels

Comments

@eseiver
Copy link
Collaborator

eseiver commented Sep 25, 2017

Right now, the unit tests do simple transformations from DOIs to URLs to file paths. What might be other unit tests to include? Ideas:

  • whether the example url links to XML are valid & the downloaded file is valid
  • whether an example solr query returns expected results
  • whether XML parsing functions work as expected

Need to also allow people to test the corpus even if they haven't downloaded the corpus and if they don't have internet access. This should involve a very small directory of testing files included in the repo

@eseiver eseiver self-assigned this Sep 25, 2017
@eseiver eseiver added the 1.0 label Sep 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant