Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BoursoBank Trackers Policy #816

Merged
merged 3 commits into from
Nov 15, 2024
Merged

Add BoursoBank Trackers Policy #816

merged 3 commits into from
Nov 15, 2024

Conversation

OTA-Bot
Copy link
Contributor

@OTA-Bot OTA-Bot commented Sep 13, 2024

🔎 Inspect this declaration suggestion

Bots should take care of checking the formatting and the validity of the declaration. As a human reviewer, you should check:

  • The suggested document matches the scope of this instance: it targets a service in the language, jurisdiction, and industry that are part of those described for this instance.
  • The service name BoursoBank matches what you see on the web page, and it complies with the guidelines.
  • The service ID BoursoBank (i.e. the name of the file) is derived from the service name according to the guidelines.
  • The terms type Trackers Policy is appropriate for this document: if you read out loud the terms type tryptich, you can say that “this document describes how the writer commits to handle the object for its audience.
  • Selectors are:
    • stable: as much as possible, the CSS selectors are meaningful and specific (e.g. .tos-content rather than .ab23 .cK_drop > div).
    • simple: the CSS selectors do not have unnecessary specificity (e.g. if there is an ID, do not add a class or a tag).
  • Generated version is:
    • relevant: it is not just a series of links, for example.
    • readable: it is complete and not mangled.
    • clean: it does not contain navigation links, unnecessary images, or extra content.

If no document type seems appropriate for this document yet it is relevant to track in this instance, please check if there is already an open discussion about such a type and reference your case there, or open a new discussion if not.

Thanks to your work and attention, Open Terms Archive will ensure that high quality data is available for all reusers, enabling them to do their part in shifting the balance of power towards end users and regulators instead of spending time collecting and cleaning documents 💪


This suggestion has been created through the Contribution Tool, which enables graphical declaration of documents. You can load it on your local instance if you have one set up.

@OTA-Bot
Copy link
Contributor Author

OTA-Bot commented Nov 15, 2024

🔎 Inspect the updated declaration suggestion

A new suggestion has been made, voiding the previous ones. As a human reviewer, here are the things you should check:

  • The suggested document matches the scope of this instance: it targets a service in the language, jurisdiction, and industry that are part of those described for this instance.
  • The service name BoursoBank matches what you see on the web page, and it complies with the guidelines.
  • The service ID BoursoBank (i.e. the name of the file) is derived from the service name according to the guidelines.
  • The terms type Trackers Policy is appropriate for this document: if you read out loud the terms type tryptich, you can say that “this document describes how the writer commits to handle the object for its audience.
  • Selectors are:
    • stable: as much as possible, the CSS selectors are meaningful and specific (e.g. .tos-content rather than .ab23 .cK_drop > div).
    • simple: the CSS selectors do not have unnecessary specificity (e.g. if there is an ID, do not add a class or a tag).
  • Generated version is:
    • relevant: it is not just a series of links, for example.
    • readable: it is complete and not mangled.
    • clean: it does not contain navigation links, unnecessary images, or extra content.

This suggestion has been created through the undefined, which enables graphical declaration of documents. You can load it on your local instance if you have one set up.

@Cli4d
Copy link
Member

Cli4d commented Nov 15, 2024

Thank you for your contribution! I made a small adjustment to the selectors to enhance stability. I replaced the descendant selectors with simpler ones that still cover the main content. Other than that, great work! I will proceed to merge your contribution.

@Cli4d Cli4d merged commit 8e96d1a into main Nov 15, 2024
3 checks passed
@Cli4d Cli4d deleted the add_bourso_bank_trackers_policy branch November 15, 2024 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants