Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generation of webpack as part of npm publishing step #101

Open
abhayks1 opened this issue Feb 19, 2019 · 0 comments
Open

Generation of webpack as part of npm publishing step #101

abhayks1 opened this issue Feb 19, 2019 · 0 comments

Comments

@abhayks1
Copy link
Contributor

  • Pre commit hook is there to generate webpack which generates distribution in dist directory. It should be removed.
  • Builds should not be part of the repository, but instead be done in the npm prepack script so that they are built when packaging or publishing.
    Also, a library that is published usually goes into a lib directory, not a dist directory. But that is something we also don’t do everywhere, yet. And any build artifacts should be listed in .gitignore.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant