#97 #100 SSL reverse proxies with apache and nginx for FireEdge #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dann1
changed the title
sk4zuzu
requested changes
Nov 22, 2024
roles/gui/tasks/main.yml
Outdated
| - name: Install Web Server | ||
| ansible.builtin.include_tasks: | ||
| file: "{{ role_path }}/tasks/{{ ssl.web_server }}.yml" | ||
| when: ssl.web_server in ['nginx', 'apache'] |
There was a problem hiding this comment.
Suggested change
| when: ssl.web_server in ['nginx', 'apache'] |
IMO this should be asserted in precheck, and then I'd let it simply fail here. 🤔
molecule/passenger-ha/molecule.yml
Outdated
There was a problem hiding this comment.
I think it should be renamed from passenger-ha to ssl-ha, no? 🤔
roles/gui/tasks/apache.yml
Outdated
There was a problem hiding this comment.
register: service_sunstone
can be removed I guess 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Ruby Sunstone deprecated on 6.10. FireEdge is now being served as the web UI on the web server of choice. apache and nginx as reverse proxies with ssl termination are the only choices contemplated at the moment.
Updated the GUI role and its references
sslvariablesslincludes the web server of choice. The no ssl option has been removed.Closes #97
Closes #100