From 519e862daeabe75f8d2624a6b49370aa1fea3021 Mon Sep 17 00:00:00 2001
From: jfrer <jasper.frerichs@sub.uni-goettingen.de>
Date: Fri, 19 Jul 2024 16:13:13 +0200
Subject: [PATCH 1/2] refactor: fix linting errors and warnings

---
 src/components/Workflows.vue                              | 6 +++---
 src/components/workflows/TrendLegend.vue                  | 2 +-
 src/components/workflows/WorkflowsIntroSection.vue        | 2 +-
 src/components/workflows/WorkflowsTable.vue               | 2 +-
 src/components/workflows/WorkflowsTimeline.vue            | 8 ++++----
 .../workflows/timeline/BaseTimelineDetailedChart.vue      | 2 +-
 src/components/workflows/timeline/MetricAverageChart.vue  | 8 ++++----
 src/components/workflows/timeline/TimelineItem.vue        | 2 +-
 8 files changed, 16 insertions(+), 16 deletions(-)

diff --git a/src/components/Workflows.vue b/src/components/Workflows.vue
index 773a57c..a5ad459 100644
--- a/src/components/Workflows.vue
+++ b/src/components/Workflows.vue
@@ -11,7 +11,7 @@
   import WorkflowsIntroSection from "@/components/workflows/WorkflowsIntroSection.vue"
   import filtersStore from "@/store/filters-store"
   import workflowsStore from "@/store/workflows-store"
-  import type { ReleaseInfo } from "@/types";
+  import type { ReleaseInfo } from "@/types"
 
   const { t } = useI18n()
 
@@ -70,7 +70,7 @@
       return acc
     }, {})
 
-    workflowsStore.releases = Object.keys(releasesObj).map(key => <ReleaseInfo>releasesObj[key])
+    workflowsStore.releases = Object.keys(releasesObj).map(key => releasesObj[key] as ReleaseInfo)
 
     setEvalColors(workflowsStore.runs)
 
@@ -85,7 +85,7 @@
     <div class="flex mb-6">
       <p class="text-amber-600 flex-grow-0 px-4 py-2 bg-amber-100 rounded-md text-sm"><span class="font-semibold">Disclaimer:</span> This is an experimental view.</p>
     </div>
-    <WorkflowsIntroSection :page="<'timeline'|'table'>selectedOption.value" class="mb-6"></WorkflowsIntroSection>
+    <WorkflowsIntroSection :page="selectedOption.value as ('timeline' | 'table')" class="mb-6"></WorkflowsIntroSection>
     <div class="flex mb-6">
       <SelectButton v-model="selectedOption" :options="options" optionLabel="name"></SelectButton>
       <Filters class="ml-auto"/>
diff --git a/src/components/workflows/TrendLegend.vue b/src/components/workflows/TrendLegend.vue
index 4cf71bb..a8db9d3 100644
--- a/src/components/workflows/TrendLegend.vue
+++ b/src/components/workflows/TrendLegend.vue
@@ -1,5 +1,5 @@
 <script setup lang="ts">
-const props = withDefaults(defineProps<{
+withDefaults(defineProps<{
   showTextColors: boolean
 }>(), {
   showTextColors: true
diff --git a/src/components/workflows/WorkflowsIntroSection.vue b/src/components/workflows/WorkflowsIntroSection.vue
index 983a98e..eae872e 100644
--- a/src/components/workflows/WorkflowsIntroSection.vue
+++ b/src/components/workflows/WorkflowsIntroSection.vue
@@ -3,7 +3,7 @@ import { useI18n } from 'vue-i18n'
 
 const { t } = useI18n()
 
-const props = defineProps<{
+defineProps<{
   page: "timeline" | "table"
 }>()
 </script>
diff --git a/src/components/workflows/WorkflowsTable.vue b/src/components/workflows/WorkflowsTable.vue
index f42c6f2..429de81 100644
--- a/src/components/workflows/WorkflowsTable.vue
+++ b/src/components/workflows/WorkflowsTable.vue
@@ -1,5 +1,5 @@
 <script setup lang="ts">
-import { watch, ref, onMounted, computed } from "vue"
+import { watch, ref, onMounted } from "vue"
 import { useI18n } from "vue-i18n"
 import { createReadableMetricValue, getEvalColor, mapGtId } from "@/helpers/utils"
 import type { EvaluationRun } from "@/types"
diff --git a/src/components/workflows/WorkflowsTimeline.vue b/src/components/workflows/WorkflowsTimeline.vue
index c3c4d63..1311e11 100644
--- a/src/components/workflows/WorkflowsTimeline.vue
+++ b/src/components/workflows/WorkflowsTimeline.vue
@@ -1,15 +1,15 @@
 <script setup lang="ts">
 import TimelineItem from "@/components/workflows/timeline/TimelineItem.vue"
 import Dropdown from 'primevue/dropdown'
-import { computed, onMounted, ref, watch} from "vue"
-import { EvaluationMetrics, getMaxValueByMetric} from '@/helpers/metrics'
+import { computed, onMounted, ref, watch } from "vue"
+import { EvaluationMetrics, getMaxValueByMetric } from '@/helpers/metrics'
 import { useI18n } from "vue-i18n"
 import type { DropdownOption, EvaluationResultsDocumentWide, Workflow, GroundTruth } from "@/types"
 import { DropdownPassThroughStyles } from '@/helpers/pt'
 import workflowsStore from '@/store/workflows-store'
 import filtersStore from '@/store/filters-store'
 import timelineStore from "@/store/timeline-store"
-import TrendLegend from "@/components/workflows/TrendLegend.vue";
+import TrendLegend from "@/components/workflows/TrendLegend.vue"
 import TimelineFilters from "./timeline/TimelineFilters.vue"
 
 const { t } = useI18n()
@@ -17,7 +17,7 @@ const gtList = computed<GroundTruth[]>(() => workflowsStore.gt.filter(({ id }) =
 const workflows = ref<Workflow[]>([])
 const selectedMetric = ref<DropdownOption | null>(null)
 const metrics = computed<DropdownOption[]>(() => Object.keys(EvaluationMetrics).map(key => ({ value: EvaluationMetrics[key], label: t(EvaluationMetrics[key]) })))
-const selectedMetricValue = computed<keyof EvaluationResultsDocumentWide>(() => <keyof EvaluationResultsDocumentWide>selectedMetric.value?.value || EvaluationMetrics.CER_MEAN)
+const selectedMetricValue = computed<keyof EvaluationResultsDocumentWide>(() => selectedMetric.value?.value as keyof EvaluationResultsDocumentWide || EvaluationMetrics.CER_MEAN)
 
 onMounted(async () => {
   selectedMetric.value = metrics.value[0]
diff --git a/src/components/workflows/timeline/BaseTimelineDetailedChart.vue b/src/components/workflows/timeline/BaseTimelineDetailedChart.vue
index 6240a52..a4564e6 100644
--- a/src/components/workflows/timeline/BaseTimelineDetailedChart.vue
+++ b/src/components/workflows/timeline/BaseTimelineDetailedChart.vue
@@ -213,7 +213,7 @@ function render([data, startDate, endDate, maxY]) {
       .attr('fill', colors.gray['600'])
       .style('cursor', 'pointer')
 
-    releaseGroup.on('mouseenter', function(e) {
+    releaseGroup.on('mouseenter', function() {
       this.parentElement.appendChild(this)
     })
   })
diff --git a/src/components/workflows/timeline/MetricAverageChart.vue b/src/components/workflows/timeline/MetricAverageChart.vue
index 54e6a93..51dc156 100644
--- a/src/components/workflows/timeline/MetricAverageChart.vue
+++ b/src/components/workflows/timeline/MetricAverageChart.vue
@@ -1,8 +1,8 @@
 <script setup lang="ts">
-import {computed, onMounted, ref, watch} from "vue"
+import { computed, onMounted, ref, watch } from "vue"
 import { useI18n } from 'vue-i18n'
 import OverlayPanel from "primevue/overlaypanel"
-import type {EvaluationResultsDocumentWide, EvaluationRun, TimelineChartDataPoint} from "@/types"
+import type { EvaluationResultsDocumentWide, EvaluationRun, TimelineChartDataPoint } from "@/types"
 import { metricChartTooltipContent } from "@/helpers/metric-chart-tooltip-content"
 import BaseTimelineChart from "@/components/workflows/timeline/BaseTimelineChart.vue"
 import BaseTimelineDetailedChart from "@/components/workflows/timeline/BaseTimelineDetailedChart.vue"
@@ -38,14 +38,14 @@ function init() {
 function getTimelineData(runs: EvaluationRun[], metric: string): TimelineChartDataPoint[] {
   const datesValues = runs.reduce((acc, cur) => {
     const date = new Date(new Date(cur.metadata.timestamp).setHours(0, 0, 0, 0)).toDateString()
-    const value = cur.evaluation_results.document_wide[<keyof EvaluationResultsDocumentWide>metric]
+    const value = cur.evaluation_results.document_wide[metric as keyof EvaluationResultsDocumentWide]
     if (!value || Array.isArray(value)) return acc
 
     if (!acc[date]) acc[date] = [value]
     else acc[date] = [...acc[date], value]
     return acc
   },
-  <{ [key: string]: number[] }>{})
+  {} as { [key: string]: number[] })
 
   return Object
     .keys(datesValues)
diff --git a/src/components/workflows/timeline/TimelineItem.vue b/src/components/workflows/timeline/TimelineItem.vue
index f7cb57e..45fd246 100644
--- a/src/components/workflows/timeline/TimelineItem.vue
+++ b/src/components/workflows/timeline/TimelineItem.vue
@@ -13,7 +13,7 @@ import TimelineItemMetadata from "@/components/workflows/timeline/TimelineItemMe
 import filtersStore from "@/store/filters-store"
 
 
-const props = defineProps<{
+defineProps<{
   gt: GroundTruth,
   metric: keyof EvaluationResultsDocumentWide
 }>()

From 759d015e4bd2d5574fe863d9f655d2729f3a705e Mon Sep 17 00:00:00 2001
From: jfrer <jasper.frerichs@sub.uni-goettingen.de>
Date: Fri, 19 Jul 2024 16:24:15 +0200
Subject: [PATCH 2/2] refactor: change config to resolve undefined var errors

---
 .eslintrc.cjs | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/.eslintrc.cjs b/.eslintrc.cjs
index e372d9c..64ca3f1 100644
--- a/.eslintrc.cjs
+++ b/.eslintrc.cjs
@@ -18,5 +18,8 @@ module.exports = {
     'no-debugger': process.env.NODE_ENV === 'production' ? 'error' : 'off',
     'semi': ['error', 'never'],
     'object-curly-spacing': ['error', 'always']
+  },
+  "env": {
+    "node": true
   }
 }