Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update primevue to 3.53 #104

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

chore: update primevue to 3.53 #104

wants to merge 2 commits into from

Conversation

jfrer
Copy link
Collaborator

@jfrer jfrer commented Aug 13, 2024

As mentioned in #101, for using the FloatLabel Component, the PrimeVue version needs to be >= 3.48. This PR updates PrimeVue to the newest version.

The theme didn't need to be changed, as it only got deprecated as it won't be avaivable in versions >= 4.0. I don't think we will have to upgrade to v4 anytime soon.

@jfrer jfrer requested a review from paulpestov August 13, 2024 13:43
@jfrer
Copy link
Collaborator Author

jfrer commented Aug 13, 2024

When I previewed the build, I noticed that the select all checkbox icon for the multiselect wasn't visible anymore, because the allSelected prop in the headercheckboxicon slot of the BaseMultiSelect component was undefined. I am not sure what caused this, because this prop is still in the latest version of the PrimeVue v3 documentation. Do you know what could cause this difference between dev and production?

@paulpestov
Copy link
Contributor

When I previewed the build, I noticed that the select all checkbox icon for the multiselect wasn't visible anymore, because the allSelected prop in the headercheckboxicon slot of the BaseMultiSelect component was undefined. I am not sure what caused this, because this prop is still in the latest version of the PrimeVue v3 documentation. Do you know what could cause this difference between dev and production?

You could the actual Component file in node_modules to find out what props exist and what not.

@jfrer
Copy link
Collaborator Author

jfrer commented Sep 3, 2024

When I previewed the build, I noticed that the select all checkbox icon for the multiselect wasn't visible anymore, because the allSelected prop in the headercheckboxicon slot of the BaseMultiSelect component was undefined. I am not sure what caused this, because this prop is still in the latest version of the PrimeVue v3 documentation. Do you know what could cause this difference between dev and production?

You could the actual Component file in node_modules to find out what props exist and what not.

I use a prob to check if all items are selected anyways to set the label, so I used this prop as a workaround for now in fa97faf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants