From dae13f24b0822cb2f6a92b1d51faa036dbdf395c Mon Sep 17 00:00:00 2001
From: jfrer <jasper.frerichs@sub.uni-goettingen.de>
Date: Tue, 30 Jul 2024 15:53:35 +0200
Subject: [PATCH 1/3] fix: show no results found message when filtering yields
 no results

---
 src/components/workflows/WorkflowsTimeline.vue | 3 ++-
 src/locales/de.json                            | 3 ++-
 src/locales/en.json                            | 3 ++-
 3 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/src/components/workflows/WorkflowsTimeline.vue b/src/components/workflows/WorkflowsTimeline.vue
index 9146ad9..e4853e7 100644
--- a/src/components/workflows/WorkflowsTimeline.vue
+++ b/src/components/workflows/WorkflowsTimeline.vue
@@ -61,7 +61,8 @@ watch(selectedMetric,
         <TimelineItem v-for="gt in sortedGtList" :key="gt.id" :gt="gt" :metric="selectedMetricValue" />
       </template>
       <template v-else-if="workflowsStore.gt.length > 0 ">
-        <div class="my-6">{{ $t('no_documents_selected') }}</div>
+        <div v-if="filtersStore.gt.length > 0" class="my-6">{{ t('no_results_found')}}</div>
+        <div v-else class="my-6">{{ $t('no_documents_selected') }}</div>
       </template>
       <template v-else>
         <div class="my-6">{{ $t('error_please_try_again_later') }}</div>
diff --git a/src/locales/de.json b/src/locales/de.json
index 040cedd..acc44b4 100644
--- a/src/locales/de.json
+++ b/src/locales/de.json
@@ -98,5 +98,6 @@
   "year_desc": "Zeitraum (neuster - ältester)",
   "select_a_label": "Kennzeichnung auswählen",
   "select_a_script_type": "Skript-Typ auswählen",
-  "no_labelling": "Keine Kennzeichnung"
+  "no_labelling": "Keine Kennzeichnung",
+  "no_results_found": "No results found."
 }
diff --git a/src/locales/en.json b/src/locales/en.json
index 9fce08a..d632c48 100644
--- a/src/locales/en.json
+++ b/src/locales/en.json
@@ -93,5 +93,6 @@
   "year_desc": "Time period (latest - oldest)",
   "select_a_label": "Select a label",
   "select_a_script_type": "Select a script-type",
-  "no_labelling": "No labelling"
+  "no_labelling": "No labelling",
+  "no_results_found": "No results found."
 }

From 1d88e7ec90a47efa93d57ae231b37af58eaff7e6 Mon Sep 17 00:00:00 2001
From: jfrer <jasper.frerichs@sub.uni-goettingen.de>
Date: Fri, 18 Oct 2024 16:03:10 +0200
Subject: [PATCH 2/3] fix: add german translations

---
 src/locales/de.json | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/locales/de.json b/src/locales/de.json
index 0dbff51..3c7733b 100644
--- a/src/locales/de.json
+++ b/src/locales/de.json
@@ -101,6 +101,6 @@
   "no_labelling": "Keine Kennzeichnung",
   "select_ground_truth": "Ground Truth auswählen",
   "filter_by": "Filtern nach",
-  "metric": "Metric",
-  "no_results_found": "No results found."
+  "metric": "Metrik",
+  "no_results_found": "Keine Ergebnisse gefunden."
 }

From fe24d16708d46bb080c520bd4220f21bae958bce Mon Sep 17 00:00:00 2001
From: jfrer <jasper.frerichs@sub.uni-goettingen.de>
Date: Fri, 18 Oct 2024 16:06:38 +0200
Subject: [PATCH 3/3] refactor: only switch text instead of whole div

---
 src/components/workflows/WorkflowsTimeline.vue | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/components/workflows/WorkflowsTimeline.vue b/src/components/workflows/WorkflowsTimeline.vue
index 2a31664..655af37 100644
--- a/src/components/workflows/WorkflowsTimeline.vue
+++ b/src/components/workflows/WorkflowsTimeline.vue
@@ -61,8 +61,10 @@ watch(selectedMetric,
         <TimelineItem v-for="gt in sortedGtList" :key="gt.id" :gt="gt" :metric="selectedMetricValue" />
       </template>
       <template v-else-if="workflowsStore.gt.length > 0 ">
-        <div v-if="filtersStore.gt.length > 0" class="my-6">{{ t('no_results_found')}}</div>
-        <div v-else class="my-6">{{ $t('no_documents_selected') }}</div>
+        <div class="my-6">
+          <span v-if="filtersStore.gt.length > 0">{{ t('no_results_found') }}</span>
+          <span v-else>{{ t('no_documents_selected') }}</span>
+        </div>
       </template>
       <template v-else>
         <div class="my-6">{{ $t('error_please_try_again_later') }}</div>