Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop the automation for #118661 #240314

Closed
7c6f434c opened this issue Jun 28, 2023 · 3 comments
Closed

Drop the automation for #118661 #240314

7c6f434c opened this issue Jun 28, 2023 · 3 comments
Labels
0.kind: bug Something is broken 6.topic: policy discussion

Comments

@7c6f434c
Copy link
Member

Describe the bug

GitHub action for monitoring direct pushes to master generates random false positives with no true positives in recent memory

Steps To Reproduce

Steps to reproduce the behavior:

  1. Merge a PR using the GitHub button
  2. Get slightly unlucky.
  3. Get noise notification from the action.

Expected behavior

Nothing after the merge.

Screenshots

#118661 is full of references to the noise notifications.

Notify maintainers

@domenkozar I guess?
@7c6f434c 7c6f434c added the 0.kind: bug Something is broken label Jun 28, 2023
@infinisil
Copy link
Member

I just opened an RFC to disallow direct pushes, which would resolve this: NixOS/rfcs#156

@7c6f434c
Copy link
Member Author

Yay, achievement unlocked (finally got my false positive for a web merge, from r-ryantm even)

@infinisil infinisil mentioned this issue Aug 14, 2023
Merged
@infinisil
Copy link
Member

The bot is now removed, see #249117 and #249151 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0.kind: bug Something is broken 6.topic: policy discussion
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@7c6f434c @FliegendeWurst @infinisil