Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename to nixpkgs-vet #100

Closed
philiptaron opened this issue Aug 26, 2024 · 8 comments
Closed

Rename to nixpkgs-vet #100

philiptaron opened this issue Aug 26, 2024 · 8 comments
Assignees

Comments

@philiptaron
Copy link
Contributor

The purpose of this tool is to vet nixpkgs.

There are now, as of late August 2024, 28 specific errors that this tool checks for. Some of them have to do with RFC 140 and the pkgs/by-name directory, but many of them are good hygiene for packages in general that happen to be checked as part of this migration.

As the migration completes, this tool will continue to have a place as a leveraged way to vet the contents of packages that are contributed to Nixpkgs.

We should therefore rename it to the short, punchy name of nixpkgs-vet.

@willbush
Copy link
Member

Oh think I misunderstood what you meant by #99 (comment). Want me to make a PR here to rename?

@philiptaron
Copy link
Contributor Author

Yes please! Then:

  1. An org owner can rename this repository
  2. We can make a release
  3. We can update nixpkgs

@philiptaron
Copy link
Contributor Author

All right, once we do a release, update nixpkgs, and rename the team in the org, we'll be done with this.

@infinisil
Copy link
Member

Team is renamed: https://github.com/orgs/NixOS/teams/nixpkgs-vet :)

@infinisil
Copy link
Member

Release can be done by just updating Cargo.{toml,lock}

@philiptaron
Copy link
Contributor Author

With #106, I'm calling this done.

@patka-123
Copy link

Might want to update the repo short description, since it still says "Tool to check Nixpkgs' pkgs/by-name directory"

@infinisil
Copy link
Member

Oh nice catch, changed it to "Tool to vet (check) Nixpkgs, including its pkgs/by-name directory" now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants