Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Nixpkgs diff report #187

Open
infinisil opened this issue Apr 5, 2024 · 2 comments
Open

Improve Nixpkgs diff report #187

infinisil opened this issue Apr 5, 2024 · 2 comments
Assignees

Comments

@infinisil
Copy link
Member

The current Nixpkgs diff report is rather sparse, we should improve it.

@infinisil
Copy link
Member Author

infinisil commented Apr 5, 2024

Here's a mock-up of how it could look:


Nixpkgs diff report

This shows how the changes in this PR affect Nixpkgs. This comment is continuously updated as the PR is updated and results become available. This Git branch is used for caching and can also be used to check the progress, all other links are immutable.

Using NixOS/nixpkgs@4b7a689 1 formatted using b84dba1 2 as the base.

Individual commits 3

  1. 5c5beaa (Automated Nixpkgs diffs for PRs): Nixpkgs diff +50 -40 (+1%)
  2. 5c5beaa (Some non-working commit): ❌ Build failure
  3. 5c5beaa (Some commit subject): Nixpkgs diff +40 -50 (-1%)
  4. 5c5beaa (latest commit): 🔄 In progress

All commits

Footnotes

  1. This is most most recent Nixpkgs commit before the first commit from this PR

  2. This is the first parent of the first commit from this PR

  3. Nixpkgs is reset to the base before running each commits formatter, such that intermediate commits don't affect the end result

@infinisil
Copy link
Member Author

Here's something that the report should also make clearer: #201 (comment)

@infinisil infinisil moved this to Todo in Nix formatting May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

1 participant