Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deduplicate with nix-eval-jobs #1315

Open
Ericson2314 opened this issue Dec 4, 2023 · 0 comments
Open

Deduplicate with nix-eval-jobs #1315

Ericson2314 opened this issue Dec 4, 2023 · 0 comments

Comments

@Ericson2314
Copy link
Member

Ericson2314 commented Dec 4, 2023

https://github.com/nix-community/nix-eval-jobs was forked from Hydra, because it is nice to be able to evaluate exactly as Hydra does outside of Hydra. This is a virtuous goal in my view --- a core Nix philosophy is that "everything CI does one should be able to do locally", without running Hydra locally of course.

But unfortunately Hydra still has its own hydra-eval-jobs, which means that we have two sources of truth now --- nix-eval-jobs and hydra-eval-jobs --- and nothing stops them from diverging. This is not good, and puts the original goes (do what hydra does locally without Hydra) at risk! The risk is not hypothetical: #875 changes hydra-eval-jobs to support CA derivations, and I wouldn't want nix-eval-jobs to not have this first (or, if it already does, add another implementation).

Here area a couple options on how to fix this:

  1. Make hydra depend on nix-eval-jobs. It is just an out of tree executable it will know how to use.
  2. Make the in-tree thing nix-eval-jobs, and make sure it is possible to build in isolation. Converting Hydra to use Meson (Convert build system from autotool to Meson #1392), like nix-eval-jobs does, could possibly help with this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants
@Ericson2314 and others