Add write metrics for kudo. #2630
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: liurenjie1024 <[email protected]>
liurenjie1024
force-pushed
the
ray/kudo-write-metrics
branch
from
6fe10ca
to
d8fc386
Compare
|
It introduces a breaking api change, resolved in NVIDIA/spark-rapids#11784 |
|
build |
1 similar comment
|
build |
jlowe
reviewed
Nov 27, 2024
| try { | ||
| header.writeTo(out); | ||
| } catch (IOException e) { | ||
| throw new RuntimeException(e); |
There was a problem hiding this comment.
We should not be remapping exceptions here. Someone trying to catch the IOException will fail to catch it.
jlowe
reviewed
Nov 27, 2024
| writer.copyDataFrom(buffer, offset, length); | ||
| return padForHostAlignment(writer, length); | ||
| } catch (IOException e) { | ||
| throw new RuntimeException(e); |
liurenjie1024
commented
Nov 28, 2024
| @@ -208,7 +218,7 @@ long writeToStream(Table table, OutputStream out, int rowOffset, int numRows) { | |||
| * @param numRows number of rows to write | |||
| * @return number of bytes written | |||
| */ | |||
| public long writeToStream(HostColumnVector[] columns, OutputStream out, int rowOffset, int numRows) { | |||
| public WriteMetrics writeToStreamWithMetrics(HostColumnVector[] columns, OutputStream out, int rowOffset, int numRows) { | |||
There was a problem hiding this comment.
I add this new method rather breaking old method's signature to avoid breaking api change.
|
build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr add support exporting write metrics of kudo serializer.