feat: add github ci step #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elezar
reviewed
Dec 14, 2023
| uses: actions/setup-go@v4 | ||
| with: | ||
| go-version: '1.20' | ||
| - run: make test |
There was a problem hiding this comment.
Just a note is that the the build.Tests step also runs the unit tests, although these are not as visible as your job.
There was a problem hiding this comment.
So can I assume that Build.Test doesn't really need it? I deleted it.
CoderTH
force-pushed
the
add-ut-ci-step
branch
from
439cadc
to
731670d
Compare
|
@CoderTH please sign-off your commit so that I can retrigger the checks. |
Signed-off-by: coderth <[email protected]>
CoderTH
force-pushed
the
add-ut-ci-step
branch
from
731670d
to
77e13b0
Compare
ok,done |
|
@elezar cc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new ut step to the CI pipeline