Ensure each imex domain.cliqueId has a unique set of channel numbers #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klueska
reviewed
Oct 24, 2024
elezar
reviewed
Oct 25, 2024
ArangoGutierrez
force-pushed
the
107/132
branch
from
7001dee
to
52fef8f
Compare
klueska
reviewed
Oct 25, 2024
klueska
reviewed
Oct 25, 2024
ArangoGutierrez
force-pushed
the
107/132
branch
from
52fef8f
to
4984a7c
Compare
klueska
reviewed
Oct 25, 2024
klueska
reviewed
Oct 25, 2024
ArangoGutierrez
force-pushed
the
107/132
branch
3 times, most recently
from
8240169
to
ed0b8d3
Compare
klueska
reviewed
Oct 25, 2024
klueska
reviewed
Oct 25, 2024
klueska
reviewed
Oct 25, 2024
klueska
reviewed
Oct 25, 2024
klueska
reviewed
Oct 25, 2024
klueska
reviewed
Oct 25, 2024
klueska
reviewed
Oct 25, 2024
ArangoGutierrez
force-pushed
the
107/132
branch
2 times, most recently
from
407375d
to
a8ce7ee
Compare
ArangoGutierrez
force-pushed
the
107/132
branch
from
a8ce7ee
to
4ece310
Compare
klueska
reviewed
Oct 25, 2024
ArangoGutierrez
force-pushed
the
107/132
branch
from
4ece310
to
904d968
Compare
klueska
reviewed
Oct 25, 2024
klueska
reviewed
Oct 25, 2024
klueska
reviewed
Oct 25, 2024
klueska
reviewed
Oct 25, 2024
ArangoGutierrez
force-pushed
the
107/132
branch
2 times, most recently
from
7187b88
to
833d071
Compare
klueska
reviewed
Oct 25, 2024
klueska
reviewed
Oct 25, 2024
klueska
reviewed
Oct 25, 2024
klueska
reviewed
Oct 25, 2024
ArangoGutierrez
force-pushed
the
107/132
branch
2 times, most recently
from
c9aada2
to
f24c39f
Compare
klueska
reviewed
Oct 25, 2024
ArangoGutierrez
force-pushed
the
107/132
branch
3 times, most recently
from
c035c02
to
9c4abf4
Compare
klueska
reviewed
Oct 25, 2024
Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
ArangoGutierrez
force-pushed
the
107/132
branch
from
9c4abf4
to
252bb50
Compare
|
Looking good. I have some ideas to simplify it even further, but let's do them as a follow-up. |
Thanks! |
klueska
approved these changes
Oct 25, 2024
klueska
reviewed
Oct 25, 2024
| newDriverResources.Pools[addedDomain] = generateImexChannelPool(addedDomain, ImexChannelLimit) | ||
| controller.Update(&newDriverResources) | ||
| driverResources = newDriverResources | ||
| driverResources := driverResources.DeepCopy() |
There was a problem hiding this comment.
this was a bug -- we actually want the following (i.e. no : because we want to overwrite the original):
driverResources = driverResources.DeepCopy()
It's fixed in my refactoring:
#189
| delete(newDriverResources.Pools, removedDomain) | ||
| controller.Update(&newDriverResources) | ||
| driverResources = newDriverResources | ||
| driverResources := driverResources.DeepCopy() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.