Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A Python distributed test don't exit properly when one rank fails. #3092

Open
wujingyue opened this issue Oct 3, 2024 · 1 comment
Open
Assignees
Labels
Multi-GPU Testing e.g. improving test infra and test coverage

Comments

@wujingyue
Copy link
Collaborator

This is apparently caused by the use of MPI_barrier. Because each test waits for a barrier before finishing, the failed rank(s) won't enter the barrier, causing other ranks to hang.

@wujingyue
Copy link
Collaborator Author

wujingyue commented Oct 10, 2024

This appears to be a known limitation of mpi4py: https://mpi4py.readthedocs.io/en/latest/mpi4py.run.html#exceptions-and-deadlocks. The solution proposed there is to python -m mpi4py. But I'm having troubles doing that with pytest.

My best bet so far is to expose Communicator to nvFuser's Python API and then a test fixture. Communicator::barrier doesn't suffer from this AFAIK. In addition, Communicator can host some common features between C++ tests and Python tests, e.g., #3091.

@kevinstephano kevinstephano added Testing e.g. improving test infra and test coverage Triage labels Oct 30, 2024
@wujingyue wujingyue self-assigned this Nov 1, 2024
@wujingyue wujingyue removed the Triage label Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Multi-GPU Testing e.g. improving test infra and test coverage
Projects
None yet
Development

No branches or pull requests

2 participants