Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement new auth flow #138

Merged
merged 5 commits into from
Apr 26, 2024
Merged

feat: implement new auth flow #138

merged 5 commits into from
Apr 26, 2024

Conversation

botanical
Copy link
Member

@botanical botanical commented Apr 25, 2024

Summary: Summary of changes

Addresses VEDA-134: Develop amazing new feature

Changes

  • New auth flow now has user directed to Cognito login and redirected back to the API
  • Added /auth/me endpoint
  • Deployed and tested changes on veda-pipeline-dev-jtran_workflows_http_api

PR Checklist

  • Update CHANGELOG
  • Unit tests
  • Ad-hoc testing - Deploy changes and test manually
  • Integration tests

@botanical
Copy link
Member Author

I noticed we have a changelog but it doesn't seem to be updated anymore. Should I add my changes to that, or have we decided to not use it? 🤔

@botanical botanical marked this pull request as ready for review April 25, 2024 20:36
def validated_token(
token_str: Annotated[str, Security(oauth2_scheme)],
required_scopes: security.SecurityScopes,
):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you include type hint?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ividito
Copy link
Contributor

ividito commented Apr 26, 2024

I noticed we have a changelog but it doesn't seem to be updated anymore. Should I add my changes to that, or have we decided to not use it? 🤔

I think this is an artifact of a time where we were experimenting with different ways to version deployed code and maintain release notes. On veda-backend we ended up doing this using Github releases, which is way easier than maintaining the changelog manually. It might be worth trying to crosswalk those actions into this repo to start maintaining something similar.

@smohiudd smohiudd self-requested a review April 26, 2024 14:47
workflows_api/runtime/src/auth.py Outdated Show resolved Hide resolved
@smohiudd smohiudd merged commit 2bb94b4 into dev Apr 26, 2024
3 checks passed
@botanical botanical deleted the jt/issue-113 branch April 26, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants