Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a few effects work #4

Open
Speppa opened this issue May 8, 2017 · 28 comments
Open

a few effects work #4

Speppa opened this issue May 8, 2017 · 28 comments

Comments

@Speppa
Copy link

Speppa commented May 8, 2017

First of all, thank you for you work.
I installed it through the first method, Ubuntu open correctly LogiGSK, I set the effects without any error message but most do not work.
The keyboard works fine on Windows 7. On Ubuntu 16.04 work only these types of lighting:
-EFFECTS:
fixed colour
breathing
colour cycle

-ZONES
Multimedia

It is still a step forward but I would like to be able to use more features.
I use Ubuntu 16.04 with openjdk 8.
Any suggestions? Can I fix something?
Thanks

@MohamadSaada
Copy link
Owner

Hi, what is your keyboard model?

@Speppa
Copy link
Author

Speppa commented May 8, 2017

G610 Orion Brown

@MohamadSaada
Copy link
Owner

Hi, unfortunately I only have a g910, but I could solve the issue if you can provide data dumps using Wireshark. You can search online for how to record data dumps for a usb device. It is necessary to record the dumps while implementing the effects you want in windows on a virtual machine using something like virtualbox. Please record a dump for each effect separately. It may sound hard but it is actually a lot easier than it sounds. If you need any help please let me know. I might take longer time to respond as I am really busy this month.

Regards

@Speppa
Copy link
Author

Speppa commented May 8, 2017

I am also really busy at the time, I'll write you here when I'll have the data dumps.
Thank you very much for your availability!

@bwbees0
Copy link

bwbees0 commented May 22, 2017

Hi Mohamad,

First things first -- thanks for getting this effort going!

I am using a new G910 Orion Spectrum keyboard with Fedora 25. When I set up the colors, I noticed that the pipe and back slash key ( | \ ) underneath the backspace key did not get a color when I set up all the key colors. That key had a color before I used the LogiGSK to reassign the keyboard colors, so I am wondering what might cause that.

On another note, building the rpm file conflicts with some file systems files in Fedora, but using your 3rd method seems to work just fine. The rpm error when installing the rpm is:

Error: Transaction check error:
file / from install of logigsk-1.0.0-2.noarch conflicts with file from package filesystem-3.2-37.fc24.x86_64
file /usr/bin from install of logigsk-1.0.0-2.noarch conflicts with file from package filesystem-3.2-37.fc24.x86_64

I can't figure out what is causing the conflict, but I thought I would pass the information to you anyway.

I will watch the site as I know you are busy. Let me know if you have any questions.

Cheers

@jonbitzen
Copy link
Contributor

jonbitzen commented Jun 10, 2017

Hello Mohamad,

I've had the same issue as bwbees0 with the pipe and backslash key. I know you said above that you've been busy but I'd like to bump this in case you get the time.

Thanks!

@MohamadSaada
Copy link
Owner

MohamadSaada commented Jun 13, 2017

@bwbees0 @jonbitzen Hi guys, is the backslash key always not working, or just in a specific effect. Which program layout are you guys using, and what models are your keyboards and which variant is it (US, UK,... etc). Thanks.

@MohamadSaada
Copy link
Owner

@bwbees0 The problem with the rpm file comes from the way I wrote the package build file, I forgot to mention that in order to build an rpm file, you need to do that on a Debian based distribution (I know it beats the purpose). The reason for this is that I added this option as a last minute thing and the way I did it is through using a utility that converts deb files into rpms. I hope when I get sometime I will fix this and implement it from scratch as I did with the deb file. In the meantime you can either use the provided rpm package on google drive, or better yet install using the INSTALL script which should work fine.

@bwbees0
Copy link

bwbees0 commented Jun 13, 2017 via email

@jonbitzen
Copy link
Contributor

Mohamad,

I'm using the US version of the G910 Orion Spark. I don't have any special effects like the RGB wave or anything. I configured the LogiGSK software to do regional lighting. So my F keys are green, G keys are red, keypad purple, and so on. The pipe and backslash key should be blue according to the way I've configured it, however although all my "main" keys are blue, the pipe / backslash key has no light on.

If I do something which clears the LogiGSK configuration (like booting into windows, where the Logitech software takes over) then the pipe/backslash key turns back on.

Thanks.

@MohamadSaada
Copy link
Owner

@bwbees0 I know it's not a hardware problem, I was asking to see when it happens. @bwbees0 @jonbitzen Can you please try and rebuild the package and install it again, I have made a small change that I hope might solve the problem, if it didn't please let me know.

@bwbees0
Copy link

bwbees0 commented Jun 14, 2017 via email

@bwbees0
Copy link

bwbees0 commented Jun 15, 2017

Hi Mohammed,

I rebuilt the software tonight and tried it out. What I notice when configuring the key colors is that all is fine until you save the profile or exit the LogiGSK application. As soon as you save the profile or exit the application, the color on the backslash-pipe key turns off. I tried this several times and even created a different profile file to see if that mattered. The same thing happened with both profiles. I have attached a gzipped version of my LogiGSK profile in case that helps.

You asked about any particular effect. I just picked colors out of the palette. Green G-keys, Blue F-keys, Red WASD-keys, Arrows are set to the same Blue as the F-keys, and set all other keys to white.

I also note that it works better to pick the colors in the Zones tab by starting from the bottom of the picklist. In other words, start with "keys" and work up to "Logos". If you work top - down, then the "WASD " gets overwritten by the "keys" choice.

Let me know if you have any questions.

Cheers and Thanks,
Ben

Benz-LogiGSK-Keys.gz

@MohamadSaada
Copy link
Owner

@bwbees0 Hi Ben, I was wondering are you using the set profile button, or just saving the profile, if you are setting the profile and it's not working can you please try to delete the profile and setting files in the /home/yourUserName/.config/LogiGSK/ directory and try setting the profile again, please let me know what happens.

Cheers

Mohamad

@bwbees0
Copy link

bwbees0 commented Jun 18, 2017

Hi Mohammed,

I set up a different profile on the last build. That new profile is the file I attached above. Today, I noticed the backslash-pipe key is working correctly and has a color assigned to it that matches what I set up. The only difference I can think of between rebuilding the LogiGSK package and now is that I applied a few updates to the system (new kernel etc) and rebooted. Maybe that had something to do with it. Anyway, it seems to be working fine now. I will let you know if anything else comes up.

Thanks very much!

Ben

@MohamadSaada
Copy link
Owner

Great to hear that, if you do face any other problems, please let me know.

Cheers

Mohamad

@jonbitzen
Copy link
Contributor

Mohamad,

I'm still having the issue with the pipe/backslash key. I did the following:

  • uninstalled the version I was using back in June
  • downloaded the source from the trunk in your git repo [I noticed there was a June commit which addressed the pipe/backslash issue]
  • built the debian package per the instructions
  • installed the updated debian package
  • reboot the system
  • opened the LogiGSK GUI
  • opened the Zones tab
  • selected "Keys" from the list of zones
    > selected a new color for "Keys"
    > upon selecting the new color, the keys in the main/central region of the keyboard (including the pipe/backslash key) changed color

So what happened is after I quit the GUI, the newly selected color sticks on everything in the "Keys" zone, except for the pipe/backslash, which reverted to the OFF color.

I've also tried clicking the "set" button before exiting the GUI, but I get the same result - the pipe/backslash key is off.

Thanks,

jonbitzen

@MohamadSaada
Copy link
Owner

@jonbitzen I will give it a go today and try to figure out what the issue is. It's probably a problem with the LogiGSK service, I think it's most likely a minor thing that could be fixed easily. Once I'm home I will have a look at it.

@MohamadSaada
Copy link
Owner

@jonbitzen I can't seem to find your problem. I will fix another problem with the service tonight, can you please test the new version after I submit it here tonight, and let me what happens with you. Sorry about this problem, Cheers.

@MohamadSaada
Copy link
Owner

@jonbitzen It just accord to me that the code might have been working before June, and that I might have caused the backslash issue instead of fixing it. I will try and change it back and then you can check it and let me know. Cheers.

@MohamadSaada
Copy link
Owner

@jonbitzen one more thing, is the problem only when you apply it through the zones, or is it also when you set it through the free style option, please let me know. Cheers.

@jonbitzen
Copy link
Contributor

jonbitzen commented Oct 15, 2017

I just tested it in freestyle. There is no way that can make the pipe/backslash key change color using the freestyle menu. The pipe/backslash is always off. I can see the color change in the picture of the keyboard in the logigsk window, but again the keyboard itself does nothing for that key in freestyle.

I independently verified that I was able to change the WASD keys from green to pink, just to ensure that other parts of the freestyle functionality work properly.

Thanks

jonbitzen

@MohamadSaada
Copy link
Owner

MohamadSaada commented Oct 27, 2017

@jonbitzen the problem is that I don't want to commit changes that might not be correct. The problem with the backslash is most probably because of confusion between using intl_backslash and backslash. In the UK layout I use intl_backslash, In the G910 US QWERTY layout I had originally set it to backslash and then changed it to intl_backslash after your first request. The way to check it out is to change the layout for the G910USQWERTY in src/Logi/GSeries/Libraries/Keyboard.java

public enum KeyG910USQWERTY { // 115 keys
        logo, badge,
        g1, g2, g3, g4, g5, g6, g7, g8, g9,
        f1, f2, f3, f4, f5, f6, f7, f8, f9, f10, f11, f12,
        shift_left, ctrl_left, win_left, alt_left, alt_right, win_right, ctrl_right, shift_right, menu,
        arrow_top, arrow_left, arrow_bottom, arrow_right,
        num_1, num_2, num_3, num_4, num_5, num_6, num_7, num_8, num_9, num_0, num_dot, num_enter, num_plus, num_minus, num_asterisk, num_slash, num_lock,
        esc, scroll_lock,
        insert, del, home, end, page_up, page_down, print_screen, pause_break,
        n1, n2, n3, n4, n5, n6, n7, n8, n9, n0,
        tab, caps_lock, space, backspace, enter,
        a, b, c, d, e, f, g, h, i, j, k, l, m, n, o, p, q, r, s, t, u, v, w, x, y, z,
        tilde, minus, equal,
        open_bracket, close_bracket,
        semicolon, quote,
        intl_backslash, comma, period, slash
    };

to


public enum KeyG910USQWERTY { // 115 keys
        logo, badge,
        g1, g2, g3, g4, g5, g6, g7, g8, g9,
        f1, f2, f3, f4, f5, f6, f7, f8, f9, f10, f11, f12,
        shift_left, ctrl_left, win_left, alt_left, alt_right, win_right, ctrl_right, shift_right, menu,
        arrow_top, arrow_left, arrow_bottom, arrow_right,
        num_1, num_2, num_3, num_4, num_5, num_6, num_7, num_8, num_9, num_0, num_dot, num_enter, num_plus, num_minus, num_asterisk, num_slash, num_lock,
        esc, scroll_lock,
        insert, del, home, end, page_up, page_down, print_screen, pause_break,
        n1, n2, n3, n4, n5, n6, n7, n8, n9, n0,
        tab, caps_lock, space, backspace, enter,
        a, b, c, d, e, f, g, h, i, j, k, l, m, n, o, p, q, r, s, t, u, v, w, x, y, z,
        tilde, minus, equal,
        open_bracket, close_bracket, backslash,
        semicolon, quote,
        comma, period, slash
    };

And then change src/Logi/GSeries/Keyboard/G910SparkUSQWERTY.java


case "076":
        jPanelColour076.setBackground(jColorChooserFreeStyle.getColor());
        jLayeredPane1.moveToBack(jPanelColour076);
        gKeyboard.setKey("intl_backslash", hexColour, true);
        break;

to


case "076":
        jPanelColour076.setBackground(jColorChooserFreeStyle.getColor());
        jLayeredPane1.moveToBack(jPanelColour076);
        gKeyboard.setKey("backslash", hexColour, true);
        break;

After you make these two changes to the source, run the sudo bash logigsk-buildpackage deb to compile the program and build a new package. Install that package and check if it works out. If it does, we will then commit the changes here, it really should only take you around 5 mins. Let me know how things go.


P.S.(Download latest source as there has been some minor changes)

@bwbees0
Copy link

bwbees0 commented Oct 27, 2017

Hi Mohamad,

Thanks for posting the above. I notice the G910 has 125 keys. What would be an easy way to add the missing keys? For example, the media control keys and the M1-M4 keys are missing in the above KeyG910USQWERTY description. I'd like to help, but I could use some advice on how to proceed.

Thanks,
Ben

@MohamadSaada
Copy link
Owner

@bwbees0 actually if you notice in src/Logi/GSeries/Libraries/Keyboard.java that the main enumeration has 127 keys to represent all keys. But the individual enumerations for each keyboard layout only represents the keys that have controllable leds. That is why the G910 is only represented by 115 keys for USQWERTY and 116 for UKQWERTY layouts. As the media keys and M keys leds can't be changed, not even in the Logitech official software. So there is no point in adding them to the layout enumeration.

@bwbees0
Copy link

bwbees0 commented Oct 31, 2017

Hi Mohamad,

Thanks for that explanation. I did not know that.

So, what would it take to get the media keys working then? The LED colors are working great, but the keys are essentially non operational right now in that the volume and cd player controls don't work on the Linux machine.

Thanks in advance,
Ben

@MohamadSaada
Copy link
Owner

@bwbees0 Hi Ben, to get the M-keys and G-keys working, we need to write a kernel driver for the Logitech keyboards. That way we can map these keys correctly and we can also introduce other effects such as the lightning effect and the key stroke effect. But unfortunately as with most things in life, this is easier said than done. Implementing it would take a large amount of time which unfortunately I don't have at the moment. But I will eventually do it, I am hoping sometime around the beginning of the new year.

Cheers

Mohamad

@bwbees0
Copy link

bwbees0 commented Nov 1, 2017

Hi Mohamad,
Wow, I did not realize that much work was involved. All the more reason to be thankful for your help! I don't know how to write kernel drivers, maybe I should start learning how to do that.

I look forward to seeing this all come together.

Cheers,
Ben

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants