Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forbid (or warn) from creation of series with same CV id #289

Open
rad96 opened this issue Oct 22, 2024 · 2 comments
Open

Forbid (or warn) from creation of series with same CV id #289

rad96 opened this issue Oct 22, 2024 · 2 comments

Comments

@rad96
Copy link

rad96 commented Oct 22, 2024

On try of series creation with CV id already present - forbid user from creation or at least warn and show possible duplication

Can probably be applicable to issues too

@rad96 rad96 changed the title Forbid (or warn) from creation series with same CV id Forbid (or warn) from creation of series with same CV id Oct 22, 2024
@bpepple
Copy link
Member

bpepple commented Oct 22, 2024

Unfortunately, Comic Vine reuses their object ID's, which came to light when they started consolidating their TPB's under one series name, so making that unique could cause problems.

Currently our series model requires a series to be unique based on the following fields:

unique_together = ["publisher", "imprint", "name", "volume", "series_type"]

I have been thinking about modifying this to some like ["publisher" "name", "volume"], but I need to do some queries of the DB and subsequent testing to make sure it wouldn't break anything.

@rad96
Copy link
Author

rad96 commented Oct 22, 2024

I know they reuse stuff, so that why I said warning would be good enough. Just to say to person "Mate, to be sure, check that out, maybe you creating duplicate - link to something"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants