Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attribution model data should be unique to prevent duplicates #118

Open
bpepple opened this issue Jun 10, 2022 · 1 comment
Open

Attribution model data should be unique to prevent duplicates #118

bpepple opened this issue Jun 10, 2022 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@bpepple
Copy link
Member

bpepple commented Jun 10, 2022

Describe the bug
Right now there is no validation done on new Attribution objects to verify the data isn't duplicated.

To Reproduce
Noticed this when I update the 'Marvel Update' command, and got duplicate Attribution data.

Expected behavior
New Attribution objects shouldn't be created.

Additional context
Need to either add a unique_together constraint or other type of check.

@bpepple bpepple added the bug Something isn't working label Jun 10, 2022
@bpepple bpepple self-assigned this Jun 10, 2022
@bpepple
Copy link
Member Author

bpepple commented Jun 10, 2022

For now, dd96825 should fix the 'update_marvel' command, but should look further into whether it makes sense to add a constraint of some kind to the model.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant