Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance filtercell with namespace and rework some filtering technical debt #408

Open
zsinnema opened this issue Dec 16, 2019 · 0 comments
Open
Labels

Comments

@zsinnema
Copy link

zsinnema commented Dec 16, 2019

See also #378

feature: enhance FilterCell with namespace so it can set/get the value via the filteringservice with the namespace via the filtername.

tech debt: cleanup/remove filtering code in the components (e.g.

FilteringService.getInstance().setFromGLobalFilters( this.props.onFilterUpdate);
)

tech debt: rework getNamespaceFromKey (

static getNamespaceFromKey (key, namespace) {
) remove hardcoded key names

@zsinnema zsinnema changed the title Enhance filtercell with namespace and rework some filtering technical dept Enhance filtercell with namespace and rework some filtering technical debt Dec 16, 2019
@zsinnema zsinnema added the tech dept Technical Debt label Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant