User Enhancements #49
Conversation
michaelpelletier
commented
May 31, 2016
•
michaelpelletier
commented
- Tweaks to the Splash page based on Kevin's comments / changes.
- Database changes:
- Add Team table.
- Add Team Role table.
- Change User Table to reference both Team Table and Team Role table.
- Add Seed Data
- Change Income to reference Team table instead of being a string.
- Change Public Relations to reference Team table instead of being a string.
- Change Bonus Credits to reference Team table instead of being a string.
- Adjust styling for Listing Users / Editing User.
- Add view for Add User
- Add views for Adding/Editing Teams.
- Add/Edit user is not saving correctly.
| end | ||
|
|
||
| # POST /user | ||
| # POST /user.json | ||
| def create | ||
| @user = User.new(user_params) | ||
| puts "NEW USER" | ||
| puts @user |
There was a problem hiding this comment.
This was me testing and should be removed, but FYI it never seems to actually get to this point.
|
The reason edit/new isn't working is because your form routes to Users::RegistrationsController instead of UsersController. This is because Devise gem overrides the registration process to handle that. I think removing that override in the routes.rb:7 might be the easy fix but it might not be... |
|
Okay I'm done for now. I'll poke around some more once we settle down on schema changes. |
michaelpelletier
force-pushed
the
user-controls
branch
from
bfa9476
to
07219a1
Compare
|
@FifthSurprise - I didn't remove the seed data for countries yet because I'm not sure how we want to handle it, but I did add views (that work!) for adding other countries. I am not sure what these lines are meant to do, so I am not sure if they still work - https://github.com/MegaGameSociety/WatchTheSkiesDashboard/blob/develop/app/controllers/games_controller.rb#L30 I also am having an issue with this where creating a User doesn't seem to work - it redirects to the Splash Page. Other than those two things, this should possibly be finished! |
|
Those lines represent the conversion of income level to the # of credits they receive. It's different per country and should probably get moved into the Team Structure/Seed Data at some point. I'll make a separate ticket for this. |
|
Oh, I didn't know that was a thing, but that makes sense. |
|
Opened #51 to follow-up on some of the future enhancements to the Team Creation feature introduced in this pull request. |
