Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build error using mks tinybee board #27553

Closed
1 task done
moriamoria opened this issue Nov 30, 2024 · 8 comments · Fixed by #27561
Closed
1 task done

Build error using mks tinybee board #27553

moriamoria opened this issue Nov 30, 2024 · 8 comments · Fixed by #27561

Comments

@moriamoria
Copy link

Did you test the latest bugfix-2.1.x code?

Yes, and the problem still exists.

Bug Description

Hello,

after my MKS skr 1.4 died, I have order a tinybee motherboard.

Whan I change the motherboard in Marlin, I have a buld error

//#define MOTHERBOARD BOARD_RAMPS_14_EFB
#define MOTHERBOARD BOARD_MKS_TINYBEE

PS C:\Users\mat\Documents\matthieu\3D\orthur\m2.1.bugfix.1\Marlin> platformio run --silent -e mks_tinybee
'"CC"' n'est pas reconnu en tant que commande interne
ou externe, un programme ex\x82cutable ou un fichier de commandes.
Error: Failed to parse Marlin features. See previous error messages.

Many thanks if you can help me to use my new tinybee board
Marlin.zip

Bug Timeline

new bug

Expected behavior

Buld should be ok and deliver a firmware.bin

Actual behavior

error when building

Steps to Reproduce

create folder ./marlin.2.1.bugfix
git clone https://github.com/MarlinFirmware/Marlin.git
open vscode
show ABM Panel

Version of Marlin Firmware

[cron] Bump distribution date (2024-11-28)

Printer model

ortur

Electronics

tinybee

LCD/Controller

REPRAP_DISCOUNT_FULL_GRAPHIC_SMART_CONTROLLER

Other add-ons

2209

Bed Leveling

UBL Bilinear mesh

Your Slicer

Cura

Host Software

OctoPrint

Don't forget to include

  • A ZIP file containing your Configuration.h and Configuration_adv.h.

Additional information & file uploads

I have done the same steap with https://github.com/makerbase-mks/MKS-TinyBee/tree/main

and I can build firmwre (but this is version 2.0)

@moriamoria
Copy link
Author

Hello,

Following previous request, I have by dichotomie try to find a point of failure:

  1. Marlin 2.1 OK
  2. Marlin 2.1.2 ok
  3. Marlin 2.1.2.3 ok
  4. Marlin 2.1.2.5 ok
  5. 📝 Update HAL documentation, README 24/11/2024 07:00:32 ok
  6. marlin 30/11/2024 21:25:55 📌 Update, pin LPC PIO framework (📌 Update, pin LPC PIO framework #27554) ko

For the moment, I don't find reason, look CC is c compiler ?

Thanks for your help

Regards

@ellensp
Copy link
Contributor

ellensp commented Dec 1, 2024

seem to be windows specific, no issues on linux, but I can replicate on windows

@ellensp
Copy link
Contributor

ellensp commented Dec 1, 2024

In f2d585a

a section was added

                # Skip '*-elf-g++' (crosstool-NG)
                if not gpath.stem.endswith('-elf-g++'):
                    gccpath = str(gpath.resolve())
                    break

But the compiler for esp32 is a -elf-g++ eg .platformio/packages/toolchain-xtensa32/bin/xtensa-esp32-elf-g++

So it cannot find the the compiler and default to CC and fails.

@thinkyhead is there a more exact string you can look for to exclude this crosstool-NG

@ellensp
Copy link
Contributor

ellensp commented Dec 1, 2024

ok this looks like a good work around to me.

change if not gpath.stem.endswith('-elf-g++'):
to if not "xtensa32" not in str(gpath) and gpath.stem.endswith('-elf-g++'):

@GonzoMDC
Copy link

GonzoMDC commented Dec 1, 2024

Made above changes and now get Invalid syntax error. Latest Marlin 2.1.X bug fix, Windows 10, Vs code PIO and MAB all up to date. Compiling for Neptune 2S with MKS Tinybee. Not proficient in Python, searching all morning for fix to no avail.
image

@ellensp
Copy link
Contributor

ellensp commented Dec 1, 2024

the code should end up looking like

                # Skip '*-elf-g++' (crosstool-NG)
                if not "xtensa32" not in str(gpath) and gpath.stem.endswith('-elf-g++'):
                    gccpath = str(gpath.resolve())
                    break

@GonzoMDC
Copy link

GonzoMDC commented Dec 2, 2024

I mad a mistake on the additions to the code. This fix DOES work. Thank you so very much for your time and effort

@thisiskeithb thisiskeithb linked a pull request Dec 2, 2024 that will close this issue
@ellensp
Copy link
Contributor

ellensp commented Dec 2, 2024

A PR has been created to fix this.

@ellensp ellensp closed this as completed Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants