Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Build fails using FYSETC_F6_14 due to missing fysetc_f6_14 board #20505

Closed
canihavesomecoffee opened this issue Dec 18, 2020 · 11 comments · Fixed by #20507
Closed

[BUG] Build fails using FYSETC_F6_14 due to missing fysetc_f6_14 board #20505

canihavesomecoffee opened this issue Dec 18, 2020 · 11 comments · Fixed by #20507

Comments

@canihavesomecoffee
Copy link

Bug Description

When cloning Marlin, and trying to set up Marlin with PlatformIO through CLion, it always fails with the next error:

/home/me/.local/bin/platformio init --ide clion

The current working directory /home/me/Documents/3D_printing/firmware_compilation/SKR-1.1-FFS will be used for the project.

The next files/directories have been created in /home/me/Documents/3D_printing/firmware_compilation/SKR-1.1-FFS
include - Put project header files here
lib - Put here project specific (private) libraries
src - Put project source files here
platformio.ini - Project Configuration File
Error: Unknown board ID 'fysetc_f6_14'

Process finished with exit code 1

Configuration Files

N/A for this bug

Steps to Reproduce

  1. Clone Marlin, optionally check out to a tag
  2. Open the project in CLion and let it initialize (using the platformio init --ide clion), or alternatively initialize it yourself through a terminal
  3. Note that it errors with the error reported above

Expected behavior:

PlatformIO initializes correctly

Actual behavior:

PlatformIO errors out with "Unknown board ID 'fysetc_f6_14'"

Additional Information

If I comment out the section of the fysetc board, it works as intended, and then I can use CLion in combination with PlatformIO.

@rhapsodyv
Copy link
Member

rhapsodyv commented Dec 18, 2020

Last time I checked, CLion didn't work fine with PIO yet. Which version are you using?

@canihavesomecoffee
Copy link
Author

canihavesomecoffee commented Dec 19, 2020

Last time I checked, CLion didn't work fine with PIO yet. Which version are you using?

PIO is version 5.0.3, CLion is version CLion 2020.3 (CL-203.5981.166, built on December 1, 2020).

This issue has been persisting for a couple of months already, but last time I thought it was indeed related to the bad support of CLion. That has improved though (now you can select a PIO target for CMake builds and select the proper board whereas 2 months ago you had to do some trickery), but this error with the Unknown board ID remains unfortunately.

Edit: And as stated, once that board is commented out, the init completes succesfully...

@ellensp
Copy link
Contributor

ellensp commented Dec 19, 2020

Platformio also doesn't know about this board
I you set motherboard BOARD_FYSETC_F6_14 and default_envs = FYSETC_F6_14
you get this error

> Executing task: pio run <

Processing FYSETC_F6_14 (platform: atmelavr; board: fysetc_f6_14; framework: arduino)
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Error: Unknown board ID 'fysetc_f6_14'
The terminal process "pio 'run'" terminated with exit code: 1.

Looks like it is only for arduino ide so far see https://wiki.fysetc.com/F6_V1.3/

@rhapsodyv
Copy link
Member

It's not a Marlin bug. PIO don't ship with this board. It has even a PR opened for that here: platformio/platform-atmelavr#180

But we can copy that board file to marlin buildroot/share/PlatformIO/boards folder. It may solve both issues.
https://raw.githubusercontent.com/platformio/platform-atmelavr/200d0e0150094286dc6b7bf9ebb3551ae4edf8bc/boards/fysetc_f6_14.json

@rhapsodyv rhapsodyv changed the title [BUG] platformio init fails (using CLion) due to fysetc_f6_14 board [BUG] Build fails using FYSETC_F6_14 due to missing fysetc_f6_14 board Dec 19, 2020
@rhapsodyv
Copy link
Member

This should fix it: #20507

@canihavesomecoffee
Copy link
Author

It's not a Marlin bug. PIO don't ship with this board. It has even a PR opened for that here: platformio/platform-atmelavr#180

But we can copy that board file to marlin buildroot/share/PlatformIO/boards folder. It may solve both issues.
https://raw.githubusercontent.com/platformio/platform-atmelavr/200d0e0150094286dc6b7bf9ebb3551ae4edf8bc/boards/fysetc_f6_14.json

I tried this out, and it does fix the issue indeed. Thank you for tracking this down and opening the PR 👍

Leaves me to wonder why no others encountered this before (although that can probably be explained because most will use PlatformIO through VS code, where this error doesn't surface for whatever reason)...

@rhapsodyv
Copy link
Member

Leaves me to wonder why no others encountered this before (although that can probably be explained because most will use PlatformIO through VS code, where this error doesn't surface for whatever reason)...

Well.... when the fix is so simple (like just copying a file), some users that find it on forums and copy the file... or, no one are using that board :-p

@canihavesomecoffee
Copy link
Author

canihavesomecoffee commented Dec 19, 2020

@rhapsodyv Just an FYI, I now encounter the same issue (being on the bugfix-2.0.x branch right now) with the megamega1280 board, which was added/modified in #20493. I guess I'll download the JSON from here (https://raw.githubusercontent.com/platformio/platform-atmelavr/7d3906c20d32751459e95fb74041e64f7a1160bf/boards/megaatmega1280.json) (looks like this should be megaatmega1280 instead?), but this might be confusing for new users if they get missing boards...

@rhapsodyv
Copy link
Member

Sure, looks like a typo! I will fix. Thanks!

@sjasonsmith sjasonsmith linked a pull request Dec 20, 2020 that will close this issue
@sjasonsmith
Copy link
Contributor

It looks like that last item was fixed in 777c50a

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Feb 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants