Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spectators #25

Open
xenonca opened this issue Nov 30, 2021 · 3 comments
Open

Spectators #25

xenonca opened this issue Nov 30, 2021 · 3 comments

Comments

@xenonca
Copy link
Contributor

xenonca commented Nov 30, 2021

Finally add a working spectator mod(e) for staff. I've made two PRs for CTF V2 to fix the encountered issues which were approved by a bunch of people and they were for some incomprehensible reason still refused to being merged. This should IMO include:

  • visual invisibility, ofc not only but especially when joining the game
  • not being pointable
  • a /watch command that doesn't get the spectator uncovered when the watched player does /m
  • no join or leave messages
  • do not show full privs list of spectators to normal players
  • do not show spectators in /team, /who or /status
  • exclude spectators from the match summary or rankings if possible
  • anything else?
    Conclusio: Spectators should be completely inexistant to normal players
    Maybe you can use this as some kind of checklist @olliy1or as I've seen you've been working on a new PR already.
@olliy1or
Copy link
Member

olliy1or commented Dec 1, 2021

Finished tasks from #25 (comment)

  • visual invisibility, ofc not only but especially when joining the game
  • not being pointable
  • a /watch command that doesn't get the spectator uncovered when the watched player does /m
  • no join or leave messages
  • exclude spectators from the match summary or rankings if possible

@LoneWolfHT
Copy link
Member

LoneWolfHT commented Jun 29, 2022

  • Spectator sometimes loses invisibility when at /unwatch or a new match
  • Nametag sometimes shows up(?)

@magnetar47
Copy link

  • Spectator join/leave messages are posted on IRC, and subsequently relayed to Discord.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants