Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow saving without custom plugin #96

Closed
ianjennings opened this issue Aug 12, 2020 · 1 comment · Fixed by #100
Closed

Allow saving without custom plugin #96

ianjennings opened this issue Aug 12, 2020 · 1 comment · Fixed by #100
Assignees
Labels
Bug High Priority We should get to this ASAP

Comments

@ianjennings
Copy link
Member

ianjennings commented Aug 12, 2020

Right now we need to have a custom plugin before any of the server functions work. We shouldn't have to have a custom plugin on the client to save.

image

@garrettluu says:

figured it out! this bug ONLY happens when we have no custom plugin
so it probably does something weird when trying to encode an empty string

See #93.

@ianjennings ianjennings added the High Priority We should get to this ASAP label Aug 12, 2020
@ianjennings ianjennings added this to the #3 - 8/14/2020 milestone Aug 12, 2020
@garrettluu
Copy link
Member

I believe this is an issue with how REPLState encodes and decodes empty strings; the backend should already be able to handle this. As you mentioned this morning, we can modify REPLState to store raw strings instead of base64 encoding and it will probably fix this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug High Priority We should get to this ASAP
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants