Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store the code blob in s3 rather than in MongoDB #32

Open
ianjennings opened this issue Jul 28, 2020 · 5 comments
Open

Store the code blob in s3 rather than in MongoDB #32

ianjennings opened this issue Jul 28, 2020 · 5 comments
Assignees
Labels

Comments

@ianjennings
Copy link
Member

ianjennings commented Jul 28, 2020

  • Configure a .env file to include AWS key and secret
  • Create a "signed upload URL on the server"
  • Pass the URL to the client
  • Allow the client to upload the javascript
  • Store the location of the JS on the server

Simple tutorial here
https://softwareontheroad.com/aws-s3-secure-direct-upload/

Things that need to be uploaded:

  • Custom test code
  • Custom plugin source

Things stored in db:

  • Babel configs
@ianjennings ianjennings added Low Priority Would be great if we could get to this. Server labels Jul 28, 2020
@wlawt
Copy link
Member

wlawt commented Jul 30, 2020

Related to #25 and will close the issue

@wlawt wlawt added this to the #1 - 7/31/2020 milestone Jul 30, 2020
@wlawt wlawt removed the Low Priority Would be great if we could get to this. label Jul 30, 2020
@wlawt
Copy link
Member

wlawt commented Jul 31, 2020

Moving to Milestone 2 since we'll be discussing the tradeoffs between MongoDB and S3, and the use cases where each will be needed.

We can start implementing this next week.

@wlawt wlawt modified the milestones: #1 - 7/31/2020, #2 - 8/7/2020 Jul 31, 2020
@wlawt
Copy link
Member

wlawt commented Jul 31, 2020

We'll still be using S3 for the plugins and input code as mentioned in today's post-retro

@mohammedsahl
Copy link
Member

To be clear, the code that stores the source/plugin/configs into an S3 bucket lives on the client side, correct? @kirbygit and I were a bit confused since there is a Server label
@wlawt @ianjennings

@wlawt
Copy link
Member

wlawt commented Aug 5, 2020

@kirbygit showed me a quick snippet of his code - it looked like he used express.js and was going to transfer it to sails.js.

I believe the goal is to just return a URL back to a client, so it can exist as an endpoint in the server, or if it can all be done using Axios in the front-end that works, too!

cc: @ianjennings

@wlawt wlawt modified the milestones: #2 - 8/7/2020, #3 - 8/14/2020 Aug 7, 2020
@wlawt wlawt modified the milestones: #3 - 8/14/2020, Backlog Aug 12, 2020
@ianjennings ianjennings removed this from the Backlog milestone Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants