Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Locale of kitinerary #18

Open
1 task
MCMic opened this issue Oct 19, 2022 · 1 comment · May be fixed by #20
Open
1 task

Locale of kitinerary #18

MCMic opened this issue Oct 19, 2022 · 1 comment · May be fixed by #20
Assignees
@MCMic

Comments

@MCMic
Copy link
Owner

MCMic commented Oct 19, 2022

Data generated by kitinerary (event name and description) is in french on my test setup. So I think it uses the locale of the system when calling kitinerary binary.
This should be changed to use the user locale, or be configurable.

  • Double check current behavior
@MCMic MCMic self-assigned this Oct 19, 2022
@MCMic MCMic linked a pull request Oct 24, 2022 that will close this issue
Draft
@MCMic
Copy link
Owner Author

MCMic commented Jan 10, 2023

Findings:

  • Using putenv('LC_ALL='.$locale); before calling kitinerary works
  • It needs a locale in long format, like fr_FR.utf8
  • The locale needs to be installed on the server
  • PHP is unable to list available locales apart from calling locale -a through shell_exec

So this is getting too complicated, I think adding a setting for the locale will be required. This setting may have to be a text input given getting the list of possible locales is not easy.

So this is postponed to later, for now we will keep current behavior of using server locale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MCMic MCMic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Respect user locale when calling kitinerary-extractor - WIP MCMic/workflow_kitinerary
1 participant
@MCMic