Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for potential path traversal attack vectors #2

Open
LukasKalbertodt opened this issue Jan 22, 2021 · 0 comments
Open

Check for potential path traversal attack vectors #2

LukasKalbertodt opened this issue Jan 22, 2021 · 0 comments

Comments

@LukasKalbertodt
Copy link
Owner

I thought a bit about this problem, and right now, I don't think reinda itself can be responsible for letting a PTA through. The get method checks either self.setup.assets or self.assets. In both cases, there are only entries that were manually listed in assets!.

However: I should check this more thoroughly and reinda should help to prevent PTA vulnerabilities in user code. For example, one could disallow .. in in the asset paths. Or we can add more docs to relevant base_paths to tell users to beware of PTAs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant