Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Support for pytorch 1.13 #1502

Open
benjats07 opened this issue Dec 28, 2022 · 3 comments
Open

Support for pytorch 1.13 #1502

benjats07 opened this issue Dec 28, 2022 · 3 comments
Labels
enhancement New feature or request question Further information is requested

Comments

@benjats07
Copy link

🚀 Feature

Support for pytorch 1.13 and MPS

Motivation

I can't take advantage of MPS in macOS since is a recently added feature and lightning-flash didn't allow usage above torch 1.10

Alternatives

I already make config changes to force the installation with newer torch and torchvision versions, but seems that 'nms' isn't available on torchvision.ops.boxes and icevision request that.

@benjats07 benjats07 added enhancement New feature or request help wanted Extra attention is needed labels Dec 28, 2022
@Borda
Copy link
Member

Borda commented Jan 5, 2023

lightning-flash didn't allow usage above torch 1.10

I don't this it is an issue with Flash, as you can see our dependencies... 🐰
https://github.com/Lightning-AI/lightning-flash/blob/1e3395fe35014b997b97a59df9f8b24e0f272d1e/requirements.txt#L4
but it could come from other 3rd-party depenecy we rely on... 🤔

Said so what is your use-case and how are you installing Flash? 🦦

@benjats07
Copy link
Author

I want to train models using MPS acceleration on MacOS but this capability is only available on lastest version of Pytorch. Especifically I want to follow this https://lightning-flash.readthedocs.io/en/latest/reference/object_detection.html

@Borda
Copy link
Member

Borda commented May 12, 2023

You can try to force upgrade Torch; I think all shall be working fine...

@Borda Borda added question Further information is requested and removed help wanted Extra attention is needed labels May 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants