Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

White space/block present in the top right corner #1536 #1579

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

realJema
Copy link

Fix issue #1536

@maggienegm
Copy link
Contributor

@realJema , taking a look at this. Do you mind attaching a pic as to what your screen looks like with this solution?

@realJema
Copy link
Author

@realJema , taking a look at this. Do you mind attaching a pic as to what your screen looks like with this solution?

body background-color: green
body_title background-color: transparent
navbar-collapse background-color: transparent
with fix
Capture4

body background-color: green
body_title background-color: blue
navbar-collapse background-color: white
without fix
image

The previous fix just put everything with a background-color:white which is flawed in certain situations

@robbyoconnor
Copy link
Member

This does not count for GSoC @realJema

@realJema
Copy link
Author

@mhn94 could you review and close this. Thanks

@maggienegm
Copy link
Contributor

Hey @realJema . It seems like your fix isn't really targeting the issue at hand, which is to make the white block space blend in with the rest of the background color chosen.

Your fix removes the background colors (i.e. the primary and secondary color settings) of the elements aka making those areas of the screen transparent.
transparent-UI

Rather than changing the background-color of those elements to "transparent," have you tried to see if the HTML element(s) in the white block is missing from that CSS statement block/ruleset?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants