Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apps team remarks #93

Open
sgliner-ledger opened this issue Nov 30, 2022 · 1 comment
Open

Apps team remarks #93

sgliner-ledger opened this issue Nov 30, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@sgliner-ledger
Copy link
Contributor

  • touchableTitle parameter in useCaseSettings is not very explicit
  • have a master useCase to do every step of the review in one function call => not needed anymore thanks to modals
@sgliner-ledger sgliner-ledger added the enhancement New feature or request label Nov 30, 2022
@fbeutin-ledger
Copy link
Contributor

In :

void nbgl_useCaseSettings(const char *settingsTitle, uint8_t initPage, uint8_t nbPages, bool touchableTitle,
                          nbgl_callback_t quitCallback, nbgl_navCallback_t navCallback,
                          nbgl_layoutTouchCallback_t controlsCallback);

bool touchableTitle is obscure and sounds like something a dev can choose to use / not use
Use_cases should instead be closely related to graphical guidelines and describe the actual use_case
In this case bool isSubSettingMenu would explicitly explain when this option should be used and that it's NOT an option for devs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants