-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keeping LSST Science Pipelines as optional dependency #113
Comments
My only comment is that we try to have a conda environment people can use for imSim etc and not have to separately include packages via pip etc. If we are brining in the stack otherwise will we still get this? |
In general, I'd prefer this sort of behavior for all object types since each one can potentially introduce extra dependencies that aren't needed if one isn't simulating those particular objects. |
Yes, having the stack installed in a conda environment or otherwise would continue to work just fine. It is that I'd like to have options for Roman teams to use this without necessarily installing the LSST stack. |
Sounds good to me. I don't see any unanswered objections. Please go ahead. |
@arunkannawadi you now have write access. |
With the recent Roman-Rubin simulations,
skyCatalogs
have become an integral part of the Roman image simulations. For Roman-only simulations, we'd like to be able to use this but without bringing in the whole LSST DM stack as a dependency.I looked into the codebase and it appears to me that it might be possible to keep it as an optional dependency.
sphgeom
which is used ubiquitously in this package can be installed separately viapip
: https://github.com/lsst/sphgeom?tab=readme-ov-file#installing-with-pipgaia_object
is the only module that has the full stack dependency vialsst.meas.algorithms
,lsst.geom
andlsst.afw.table
(lsst.daf.butler
ispip
-installable). Redesigning this code such thatgaia_object
is imported explicitly/on-demand will enable using other aspects of this code without Science Pipelines.On a branch, I see Joanne is documenting the dependency on Science Pipelines, but it would be useful to keep that optional. I'm happy to make the relevant changes if the proposal sounds good.
Pinging @JoanneBogart @jchiang87
The text was updated successfully, but these errors were encountered: