Add properties parameter to all command-buffer commands #2050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EwanC
force-pushed
the
ewan/command_properties
branch
from
b26a328
to
8eb259b
Compare
Make changes to reflect OpenCL-Docs change KhronosGroup/OpenCL-Docs#1215 and requires header change KhronosGroup/OpenCL-Headers#260 to use preprocessor path with extra parameters
EwanC
force-pushed
the
ewan/command_properties
branch
from
8eb259b
to
76d1749
Compare
bashbaug
added a commit
that referenced
this pull request
Sep 6, 2024
This is an update to #2050, with updates from the main branch. --------- Co-authored-by: Ewan Crawford <[email protected]>
|
Merged with #2072, closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make changes to reflect OpenCL-Docs change KhronosGroup/OpenCL-Docs#1215 and requires header change KhronosGroup/OpenCL-Headers#260 to use preprocessor path with extra parameters
Used CL_DEVICE_EXTENSIONS_WITH_VERSION runtime check and skipped testing when a device doesn't support required versions.
Tested using OCK updated with this API change uxlfoundation/oneapi-construction-kit#519