Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance issues in you project (by P3) #45

Open
DLPerf opened this issue Aug 30, 2021 · 1 comment
Open

Performance issues in you project (by P3) #45

DLPerf opened this issue Aug 30, 2021 · 1 comment

Comments

@DLPerf
Copy link

DLPerf commented Aug 30, 2021

Hello! I've found a performance issue in your project: batch() should be called before map(), which could make your program more efficient. Here is the tensorflow document to support it.

Detailed description is listed below:

  • /data.py: dataset.batch(batch_size)(here) should be called before dataset.map(_parser)(here).
  • /data.py: dataset.batch(batch_size)(here) should be called before dataset.map(_parser)(here).
  • /data.py: dataset.batch(batch_size)(here) should be called before dataset.map(_preprocess_inference)(here).
  • /cGAN/data.py: dataset.batch(batch_size)(here) should be called before dataset.map(_parser)(here).
  • /cGAN/data.py: dataset.batch(batch_size)(here) should be called before dataset.map(_parser)(here).
  • /cGAN/data.py: dataset.batch(batch_size)(here) should be called before dataset.map(_preprocess_inference)(here).

Besides, you need to check the function called in map()(e.g., _preprocess_inference called in dataset.map(_preprocess_inference)) whether to be affected or not to make the changed code work properly. For example, if _preprocess_inference needs data with shape (x, y, z) as its input before fix, it would require data with shape (batch_size, x, y, z).

Looking forward to your reply. Btw, I am very glad to create a PR to fix it if you are too busy.

@Justin-Tan
Copy link
Owner

Hey, this looks good, unfortunately it's been a while since I looked at the codebase. I agree from the documentation that this should increase performance. Happy to accept a PR if you create it for this and any other issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants