Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Questions about encoding #32

Open
shellhuang1227 opened this issue Jul 30, 2019 · 6 comments
Open

Questions about encoding #32

shellhuang1227 opened this issue Jul 30, 2019 · 6 comments

Comments

@shellhuang1227
Copy link

Hello, while reading the paper, it proposed "When encoding the channels of w^ to a bit-stream, we use an arithmetic encoder where frequencies are stored for each channel separately and then encode them in a static (non-adaptive) manner (i.e. context model and adaptive arithmetic encoding)."
But in your code, the quantized value w^ is concatenated with noise v to form the latent vector z, and then the generator G tries to generate an image x^ = G(z). I did not find the step: encoding the channels of w^ to a bit-stream in context model and adaptive arithmetic encoding. Did you not conside this step?
Thank you very much.

@Justin-Tan
Copy link
Owner

Justin-Tan commented Jul 31, 2019 via email

@shellhuang1227
Copy link
Author

Yeah, I know it’s from section 4.1 of the paper.
But "encoding the channels of w^ to a bit-stream in context model and adaptive arithmetic encoding" come from section 5.1 of the paper. However, I did not find it in your code.
Thank you very much

@Justin-Tan
Copy link
Owner

Justin-Tan commented Jul 31, 2019 via email

@shellhuang1227
Copy link
Author

Yeah, very looking forward to it.
By the way, the lack of the step I mentioned above will not influence the overall network's capability and just reduced the compression ratio, right?
Thanks for your reply.

@Justin-Tan
Copy link
Owner

Justin-Tan commented Jul 31, 2019 via email

@shellhuang1227
Copy link
Author

OK. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants