Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add LMS and DKL color space colorschemes? #55

Open
babaq opened this issue Dec 15, 2020 · 6 comments
Open

add LMS and DKL color space colorschemes? #55

babaq opened this issue Dec 15, 2020 · 6 comments

Comments

@babaq
Copy link

babaq commented Dec 15, 2020

Hi,

I have generated and used some basic colormaps for color science studies. These include:

LMS Cone Isolating colors
image

DKL Cone-Opponent colors
image

DKL Isoluminance Hues
image

and other variants.

I am wandering if these colormaps are of more general interests, so anyone can easily get access to them if they were included in the predefined colorschemes.

@cormullion
Copy link
Member

Sounds like a good idea!

Most of the predefined colorschemes here are"documented" elsewhere, with a link to the originating site (see https://juliagraphics.github.io/ColorSchemes.jl/latest/basics/). And there are usually license files to go with them, in /data. So you could explain and document them somewhere (eg your web site) and "publish" them, then it's easy to include them here with a suitable link to "the source".

@cormullion
Copy link
Member

Did you get round to writing these up somewhere?

@babaq
Copy link
Author

babaq commented Mar 22, 2021

i have these scattered in several packages, do you suggest create a new small pacakge only for them, or i could move them all into one packages(the ColorLab)?

@cormullion
Copy link
Member

Well it's just that there's not enough space to describe each colour scheme in any detail in the docs, so I like to just add a link to a place where the purpose and nature of the schemes is provided in more detail. Eg for cmocean I can just link to their site (https://juliagraphics.github.io/ColorSchemes.jl/latest/basics/#cmocean) where they have all the credits, etc..

To be honest I suppose it could just be a README.md or a section in any documentation you might already have. :)

@babaq
Copy link
Author

babaq commented Mar 23, 2021

I see your point. what about the scheme data, right now I save them in a JLD2 file, and loaded in package init(), but I remember some of the concreate colors in Colors.jl are written down directly in the source file, is this the way of colorschemes?

@cormullion
Copy link
Member

Yes, every colorscheme in this package is simply an array of RGB{Float64}. The idea of the package is simply to act as a simple catalogue of pre-defined colorschemes - unlike some other packages where colorschemes are generated when required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants