-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
N-argument convolution #338
Open
HDictus
wants to merge
34
commits into
JuliaDSP:master
Choose a base branch
from
HDictus:newNargs
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on May 15, 2019
-
I have added an overlap-save algorithm to convolution, which is substantially faster (~2x) for large convolution problems. It is also substantially faster than other packages like ImageFiltering.jl. For smaller convolutions, it is about the same or a little bit slower than standard fft convolution. The cutoff between overlap-save and simple fft convolution is pretty arbitrary at the moment, so it would be nice to add some benchmarking to allow DSP.jl to choose between the two algorithms depending on the size of the input. It would also be nice to add spatial/time domain filtering for small convolutions, as it would almost certainly be faster than fft convolutions. This is relevant to JuliaDSP#224.
Configuration menu - View commit details
-
Copy full SHA for 18ddeb1 - Browse repository at this point
Copy the full SHA 18ddeb1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3fd184d - Browse repository at this point
Copy the full SHA 3fd184dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 238472f - Browse repository at this point
Copy the full SHA 238472fView commit details -
Configuration menu - View commit details
-
Copy full SHA for e10f3da - Browse repository at this point
Copy the full SHA e10f3daView commit details -
Configuration menu - View commit details
-
Copy full SHA for a6c15a1 - Browse repository at this point
Copy the full SHA a6c15a1View commit details -
Configuration menu - View commit details
-
Copy full SHA for b875894 - Browse repository at this point
Copy the full SHA b875894View commit details -
Configuration menu - View commit details
-
Copy full SHA for c766520 - Browse repository at this point
Copy the full SHA c766520View commit details -
Configuration menu - View commit details
-
Copy full SHA for 08bcd80 - Browse repository at this point
Copy the full SHA 08bcd80View commit details -
Configuration menu - View commit details
-
Copy full SHA for 01b637b - Browse repository at this point
Copy the full SHA 01b637bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7bf3c6d - Browse repository at this point
Copy the full SHA 7bf3c6dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 92549ba - Browse repository at this point
Copy the full SHA 92549baView commit details -
Configuration menu - View commit details
-
Copy full SHA for 817f44d - Browse repository at this point
Copy the full SHA 817f44dView commit details
Commits on May 18, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 38bfd03 - Browse repository at this point
Copy the full SHA 38bfd03View commit details -
implement N-argument convolution
performs overlap-save on the first argument if it is large enough to warrant it. Performs fft convolution of all others.
Configuration menu - View commit details
-
Copy full SHA for 7fb9548 - Browse repository at this point
Copy the full SHA 7fb9548View commit details
Commits on May 21, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 849dfab - Browse repository at this point
Copy the full SHA 849dfabView commit details
Commits on May 28, 2019
-
Configuration menu - View commit details
-
Copy full SHA for e27d5b9 - Browse repository at this point
Copy the full SHA e27d5b9View commit details -
Configuration menu - View commit details
-
Copy full SHA for b226eec - Browse repository at this point
Copy the full SHA b226eecView commit details
Commits on Jun 5, 2019
-
public conv needs 2 or more arguments redundant union removed permsort with rev=true comprehension replaced with elementwise operation
Configuration menu - View commit details
-
Copy full SHA for 5f949d4 - Browse repository at this point
Copy the full SHA 5f949d4View commit details
Commits on Jun 20, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 9b31146 - Browse repository at this point
Copy the full SHA 9b31146View commit details
Commits on Jul 2, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 354fbc8 - Browse repository at this point
Copy the full SHA 354fbc8View commit details -
add some larger convolutions to test
also fix issue that test revealed
Configuration menu - View commit details
-
Copy full SHA for 715dd9f - Browse repository at this point
Copy the full SHA 715dd9fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 680a371 - Browse repository at this point
Copy the full SHA 680a371View commit details -
dispatch one and more to different filter transforms
copy only out array for complex
Configuration menu - View commit details
-
Copy full SHA for 3a3b99f - Browse repository at this point
Copy the full SHA 3a3b99fView commit details
Commits on Jul 3, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 09e8ed2 - Browse repository at this point
Copy the full SHA 09e8ed2View commit details
Commits on Jan 9, 2020
-
Configuration menu - View commit details
-
Copy full SHA for aa40c8e - Browse repository at this point
Copy the full SHA aa40c8eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1fc71f4 - Browse repository at this point
Copy the full SHA 1fc71f4View commit details -
Configuration menu - View commit details
-
Copy full SHA for e03a5ac - Browse repository at this point
Copy the full SHA e03a5acView commit details -
Configuration menu - View commit details
-
Copy full SHA for 86e6938 - Browse repository at this point
Copy the full SHA 86e6938View commit details -
Configuration menu - View commit details
-
Copy full SHA for 66b187a - Browse repository at this point
Copy the full SHA 66b187aView commit details
Commits on Jan 10, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 0441b19 - Browse repository at this point
Copy the full SHA 0441b19View commit details -
Test that old-style seperable convolution warns about the change
and test that it runs an ordinary convolution
Configuration menu - View commit details
-
Copy full SHA for 9f5c11c - Browse repository at this point
Copy the full SHA 9f5c11cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6d4916f - Browse repository at this point
Copy the full SHA 6d4916fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5924133 - Browse repository at this point
Copy the full SHA 5924133View commit details
Commits on Nov 16, 2020
-
Configuration menu - View commit details
-
Copy full SHA for feac1c7 - Browse repository at this point
Copy the full SHA feac1c7View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.