Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom constraints : add tests #128

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Custom constraints : add tests #128

wants to merge 2 commits into from

Conversation

franckgaga
Copy link
Member

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Nov 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.28%. Comparing base (58191fd) to head (aaf7c7a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #128   +/-   ##
=======================================
  Coverage   98.28%   98.28%           
=======================================
  Files          24       24           
  Lines        3664     3664           
=======================================
  Hits         3601     3601           
  Misses         63       63           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@franckgaga
Copy link
Member Author

#118 continuing the conversation here @baggepinnen

You can see the last version of the doc here:

https://juliacontrol.github.io/ModelPredictiveControl.jl/previews/PR128

@baggepinnen
Copy link
Member

Nice, this new feature is a nice addition!

Here
image

I find it a bit hard to understand what format the bold-face arguments come in, there are bold and non-bold face, capital and non capital letters. I assume these all mean something but I'm not sure what. They are somewhat defined at the top of the page in which the docstring appears, but it's still somewhat unclear since the entries in these arrays
image

are themselves arrays, making the layout of the outer array somewhat undefined. For example, is $U \in \mathbb{R}^{H_c n_u}$ or $U \in \mathbb{R}^{H_c \times n_u}$ or is $U$ a vector of vectors?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants