Optimize CI a bit #574
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,6 +18,7 @@ jobs: | |
| run: echo "The selected java versions are ${{ steps.set-matrix.outputs.version_matrix }}" | ||
| outputs: | ||
| version_matrix: ${{ steps.set-matrix.outputs.version_matrix }} | ||
|
|
||
| build: | ||
| needs: build-jvm-matrix | ||
| strategy: | ||
|
|
@@ -27,7 +28,7 @@ jobs: | |
| java_version: ${{ fromJson(needs.build-jvm-matrix.outputs.version_matrix) }} | ||
| runs-on: ${{ matrix.os }} | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - name: configure windows pagefile | ||
| if: ${{ matrix.os == 'windows-latest' }} | ||
| uses: al-cheb/[email protected] | ||
|
|
@@ -36,50 +37,23 @@ jobs: | |
| maximum-size: 8GB | ||
| disk-root: "D:" | ||
| - name: set up JDK | ||
| uses: actions/setup-java@v4 | ||
| with: | ||
| java-version: ${{ matrix.java_version }} | ||
| distribution: 'zulu' | ||
|
There was a problem hiding this comment. Does this now get handled by the Gradle Action? There was a problem hiding this comment. Nope, if we still need to cache testKit dir, can we store them to |
||
| - uses: gradle/actions/setup-gradle@v3 | ||
| with: | ||
| gradle-home-cache-cleanup: true | ||
| - name: Build plugin | ||
| run: ./plugin/gradlew -p ./plugin assemble ensureDependenciesAreInlined test --no-daemon | ||
| - name: Upload test results | ||
| uses: actions/upload-artifact@v4 | ||
| if: failure() | ||
| with: | ||
| name: test-results-${{ runner.os }} | ||
| path: plugin/build/reports/tests/test/ | ||
| - name: Upload Memory Dump | ||
| uses: actions/upload-artifact@v4 | ||
| if: failure() | ||
| with: | ||
| name: memory-dump-${{ runner.os }} | ||
|
|
@@ -95,9 +69,9 @@ jobs: | |
| runs-on: ubuntu-latest | ||
| needs: build | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - name: set up JDK 11 | ||
| uses: actions/setup-java@v4 | ||
| with: | ||
| java-version: 11 | ||
| distribution: 'zulu' | ||
|
|
@@ -109,20 +83,9 @@ jobs: | |
| run: sudo apt install -qq libdistro-info-perl | ||
| - name: Install checkbashisms | ||
| run: sudo apt-get install -qq devscripts | ||
| - uses: gradle/actions/setup-gradle@v3 | ||
| with: | ||
| gradle-home-cache-cleanup: true | ||
| - name: Check git bashisms | ||
| run: ./gradlew addKtlintCheckGitPreCommitHook --no-daemon && checkbashisms .git/hooks/pre-commit | ||
|
|
||
|
|
@@ -133,25 +96,14 @@ jobs: | |
| runs-on: ${{ matrix.os }} | ||
| needs: build | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - name: set up JDK 1.8 | ||
| uses: actions/setup-java@v4 | ||
| with: | ||
| java-version: 8 | ||
| distribution: 'zulu' | ||
| - uses: gradle/actions/setup-gradle@v3 | ||
| with: | ||
| gradle-home-cache-cleanup: true | ||
| - name: Check ktlint-plugin on samples | ||
| run: ./gradlew ktlintCheck --no-daemon | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,12 +1,18 @@ | ||
| name: "Validate Gradle Wrapper" | ||
|
There was a problem hiding this comment. I'd prefer to keep these. And I don't know if the filtering adds much value. It actual adds additional risk, as it completely misses the second Gradle wrapper in the plugins directory |
||
|
|
||
| on: | ||
| pull_request: | ||
| paths: | ||
| - 'gradlew' | ||
| - 'gradlew.bat' | ||
| - 'gradle/wrapper/' | ||
|
|
||
| jobs: | ||
| validation: | ||
| name: "Validation" | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: gradle/wrapper-validation-action@v1 | ||
| with: | ||
| min-wrapper-count: 2 | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,6 +21,7 @@ jobs: | |
| analysis: | ||
| name: Scorecard analysis | ||
| runs-on: ubuntu-latest | ||
| if: github.repository == 'JLLeitschuh/ktlint-gradle' | ||
| permissions: | ||
| # Needed to upload the results to code-scanning dashboard. | ||
| security-events: write | ||
|
|
@@ -32,7 +33,7 @@ jobs: | |
|
|
||
| steps: | ||
| - name: "Checkout code" | ||
| uses: actions/checkout@4 | ||
|
There was a problem hiding this comment. Using the exact commit hash is done intentionally. It's a suggested security measure, advised by security scorecard. There was a problem hiding this comment. We can pin them to hash, but there would be better to enable @renovate-bot for this repo to keep thing up to date. There was a problem hiding this comment. Dependabot can assist here as well I believe |
||
| with: | ||
| persist-credentials: false | ||
|
|
||
|
|
@@ -59,14 +60,14 @@ jobs: | |
| # Upload the results as artifacts (optional). Commenting out will disable uploads of run results in SARIF | ||
| # format to the repository Actions tab. | ||
| - name: "Upload artifact" | ||
| uses: actions/upload-artifact@4 | ||
| with: | ||
| name: SARIF file | ||
| path: results.sarif | ||
| retention-days: 5 | ||
|
|
||
| # Upload the results to GitHub's code scanning dashboard. | ||
| - name: "Upload to code-scanning" | ||
| uses: github/codeql-action/upload-sarif@3 | ||
| with: | ||
| sarif_file: results.sarif | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you make sure this action is being run with no credentials?