-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The plugin does not work when using Ktlint 0.46.0 #589
Comments
A PR that addresses the issue would be appreciated 🙂 |
Hey @JLLeitschuh, I have it almost ready, but it seems like it would require updating the whole project (and samples) to Kotlin 1.6.21 and then it will not be backward-compatible with earlier ktlint versions (due to 0.46 introducing breaking changes). I'll open it soon so maybe @JLLeitschuh or @Tapchicoma could take a look (I've read #569 so I know how it looks like time-wise) |
@scana could you do so in such a way that preserves backwards compatibility by using reflection to call the old APIs? |
@JLLeitschuh unfortunately not, because they have also changed |
Turns out experimental:function-signature is a feature of ktlint 0.46.+ which is something we can not use yet since the gradle plugin we're using does not support it yet, relevant issue here: JLLeitschuh/ktlint-gradle#589 This also required to downgrade to the gradle plugin ktlint version 0.9.1 from 0.10.0 so that the IDE hints do not show different rules as well.
Please take this in the light-hearted spirit it is intended but: change all the things, issue a major version (semantic-version-wise) and sleep well at night :-) |
As stated in this PR I think even though there was a 11.0.0 major release, this issue is still unchanged. |
Same issue with all ktlint versions >0.45.2, including 0.47.0 |
@DmitriyZaitsev edited his comment to be more collaborative / informative, so I am editing mine to be much more friendly :-) |
Given how long this issue has been open and unresolved, is this something we could do? Create a 12.0.0 and just say that as of that version of this plugin, only ktlint 0.46.0 and newer are supported? |
The same problem
|
This resolves JLLeitschuh#589 and JLLeitschuh#607
This resolves JLLeitschuh#589 and JLLeitschuh#607
This resolves JLLeitschuh#589 and JLLeitschuh#607
add tests for 0.44 and 0.45 as well This resolves JLLeitschuh#589 This resolves JLLeitschuh#607
add tests for 0.44 and 0.45 as well This resolves JLLeitschuh#589 This resolves JLLeitschuh#607
com.android.tools.build:gradle = "7.4.0"
|
My pr #620 will resolve this issue. I am putting the finishing touches on it and will hopefully merge it later this week |
This resolves JLLeitschuh#589 and JLLeitschuh#607
add tests for 0.44 and 0.45 as well This resolves JLLeitschuh#589 This resolves JLLeitschuh#607
add tests for 0.44 and 0.45 as well This resolves JLLeitschuh#589 This resolves JLLeitschuh#607
add tests for 0.44 and 0.45 as well This resolves JLLeitschuh#589 This resolves JLLeitschuh#607
add tests for 0.44 and 0.45 as well This resolves JLLeitschuh#589 This resolves JLLeitschuh#607
add tests for 0.44 and 0.45 as well This resolves JLLeitschuh#589 This resolves JLLeitschuh#607
add tests for 0.44 and 0.45 as well This resolves JLLeitschuh#589 This resolves JLLeitschuh#607
add tests for 0.44 and 0.45 as well This resolves JLLeitschuh#589 This resolves JLLeitschuh#607
add tests for 0.44 and 0.45 as well This resolves JLLeitschuh#589 This resolves JLLeitschuh#607
The Ktlint 0.46.0 has been released recently with breaking API changes that make using the plugin impossible. One such change is that Ktlint.Params class has been renamed into the ExperimentalParams.
As a result of this, when I run the
./gradlew ktlintCheck --continue
command, I get the following:The versions used are the following:
10.3.0
0.46.0
The text was updated successfully, but these errors were encountered: