Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permit DIDCommService type to be a list? #83

Open
dbluhm opened this issue Jan 5, 2024 · 0 comments
Open

Permit DIDCommService type to be a list? #83

dbluhm opened this issue Jan 5, 2024 · 0 comments

Comments

@dbluhm
Copy link
Member

dbluhm commented Jan 5, 2024

An aspect of services that was originally overlooked in this implementation was that the type of a service may be either a string or a list of strings. #82 corrected the base Service class to permit this; however, DIDCommService classes are still strictly expecting to be just a string. Should we update this to accept a list of strings as well?

Our current posture is to wait until this is a problem since it will require some changes to how DIDComm Services are parsed.

Thank you, @PatStLouis, for bringing the original issue up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant